Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #124646

Merged
merged 34 commits into from
May 3, 2024
Merged

Rollup of 10 pull requests #124646

merged 34 commits into from
May 3, 2024

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    1a83bea View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    6b6bc98 View commit details
    Browse the repository at this point in the history
  2. String.truncate calls Vec.truncate, in turn, and that states

    "is greater or equal to". Beside common sense.
    bravequickcleverfibreyarn committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    825a3b1 View commit details
    Browse the repository at this point in the history
  3. WS fix.

    bravequickcleverfibreyarn committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f840da7 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    42ecde4 View commit details
    Browse the repository at this point in the history
  2. library/std: Remove unused gimli-symbolize feature

    library/backtrace also declares a feature called `gimli-symbolize` which
    appear used, but the feature in std with the same name is unused, so
    remove it.
    Enselic committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9af3b1e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbe2f51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff2ff97 View commit details
    Browse the repository at this point in the history
  5. Tweak consts_may_unify.

    `ConstKind::Value` is the only variant where control flow leaves the
    first match on `impl_ct.kind()`, so there is no need for a second match
    on the same expression later on.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3722eb0 View commit details
    Browse the repository at this point in the history
  6. rustc_expand: clean up attributes.

    Sort them, and remove the unused ones (`lint_reasons` and
    `proc_macro_span`).
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    aabb90d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d817856 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7c6d363 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3f05589 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    189a8a6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e809df6 View commit details
    Browse the repository at this point in the history
  12. Inline and remove three DummyResult methods.

    They each have a single call site.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d7f5319 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c9c964f View commit details
    Browse the repository at this point in the history
  14. Remove unnecessary pubs.

    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    79c4d02 View commit details
    Browse the repository at this point in the history
  15. Tweak fully_expand_fragment loop.

    Control flow never gets past the end of the `ExpandResult::Retry` match
    arm, due to the `span_bug` and the `continue`. Therefore, the code after
    the match can only be reached from the `ExpandResult::Ready` arm.
    
    This commit moves that code after the match into the
    `ExpandResult::Ready` arm, avoiding the need for the `continue` in the
    `ExpandResult::Retry` arm.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3b69781 View commit details
    Browse the repository at this point in the history
  16. Replace a hard-to-read line.

    Too clever by half, IMO.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1c15b6a View commit details
    Browse the repository at this point in the history
  17. Introduce Invocation::span_mut.

    Alongside the existing `Invocation::span`.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ae7e328 View commit details
    Browse the repository at this point in the history
  18. Type annotate repeats.

    Because the type is not obvious, and this clarifies things.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5ac017e View commit details
    Browse the repository at this point in the history
  19. Refactor Frame.

    It is currently an enum and the `tts` and `idx` fields are repeated
    across the two variants.
    
    This commit splits it into a struct `Frame` and an enum `FrameKind`, to
    factor out the duplication. The commit also renames `Frame::new` as
    `Frame::new_delimited` and adds `Frame::new_sequence`. I.e. both
    variants now have a constructor.
    nnethercote committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3a3a15d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    3a3df3e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Rollup merge of rust-lang#123480 - Nadrieril:impl-all-derefpures, r=c…

    …ompiler-errors
    
    deref patterns: impl `DerefPure` for more std types
    
    Context: [deref patterns](rust-lang#87121). The requirements of `DerefPure` aren't precise yet, but these types unambiguously satisfy them.
    
    Interestingly, a hypothetical `impl DerefMut for Cow` that does a `Clone` would *not* be eligible for `DerefPure` if we allow mixing deref patterns with normal patterns. If the following is exhaustive then the `DerefMut` would cause UB:
    ```rust
    match &mut Cow::Borrowed(&()) {
        Cow::Owned(_) => ..., // Doesn't match
        deref!(_x) if false => ..., // Causes the variant to switch to `Owned`
        Cow::Borrowed(_) => ..., // Doesn't match
        // We reach unreachable
    }
    ```
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    e17a222 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#124412 - RalfJung:io-safety, r=Amanieu

    io safety: update Unix explanation to use `Arc`
    
    Fixes rust-lang#124384
    
    Cc ```@jsgf```
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    9ab5cfd View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#124441 - bravequickcleverfibreyarn:string.r…

    …s, r=Amanieu
    
    String.truncate comment microfix (greater or equal)
    
    String.truncate calls Vec.truncate, in turn, and that states "is greater or equal to". Beside common sense.
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    d7a8936 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#124594 - jieyouxu:rmake-cc, r=fmease

    run-make-support: preserve tooks.mk behavior for EXTRACXXFLAGS
    
    In rust-lang#123149 when trying to add a command wrapper for `cc`, I didn't preserve the behavior of tools.mk completely: tools.mk had
    
    ```makefile
    # Extra flags needed to compile a working executable with the standard library
    ifdef IS_WINDOWS
    ifdef IS_MSVC
    	#EXTRACFLAGS := ws2_32.lib userenv.lib advapi32.lib bcrypt.lib ntdll.lib synchronization.lib
    else
    	#EXTRACFLAGS := -lws2_32 -luserenv -lbcrypt -lntdll -lsynchronization
    	EXTRACXXFLAGS := -lstdc++
    	#EXTRARSCXXFLAGS := -l static:-bundle=stdc++
    endif
    else
    ifeq ($(UNAME),Darwin)
    	#EXTRACFLAGS := -lresolv
    	EXTRACXXFLAGS := -lc++
    	#EXTRARSCXXFLAGS := -lc++
    else
    ifeq ($(UNAME),FreeBSD)
    	#EXTRACFLAGS := -lm -lpthread -lgcc_s
    else
    ifeq ($(UNAME),SunOS)
    	#EXTRACFLAGS := -lm -lpthread -lposix4 -lsocket -lresolv
    else
    ifeq ($(UNAME),OpenBSD)
    	#EXTRACFLAGS := -lm -lpthread -lc++abi
    	#RUSTC := $(RUSTC) -C linker="$(word 1,$(CC:ccache=))"
    else
    	#EXTRACFLAGS := -lm -lrt -ldl -lpthread
    	EXTRACXXFLAGS := -lstdc++
    	#EXTRARSCXXFLAGS := -lstdc++
    endif
    endif
    endif
    endif
    endif
    ```
    
    Note that for {`FreeBSD`, `SunOs`, `OpenBSD`} the `-lstdc++` flag is *not* passed, so `EXTRACXXFLAGS` for those platforms should be an empty `vec![]`.
    
    r? ghost (testing this with PR CI)
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    30efce9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#124604 - Enselic:std-gimli-symbolize, r=wor…

    …kingjubilee
    
    library/std: Remove unused `gimli-symbolize` feature
    
    library/backtrace also declares a feature called `gimli-symbolize` which appear used, but the feature in std with the same name is unused, so remove it.
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    bd6276c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#124607 - nnethercote:rustc_expand-cleanups,…

    … r=compiler-errors
    
    `rustc_expand` cleanups
    
    Some cleanups I made while looking through this code. Nothing that requires any real domain-specific knowledge about this crate.
    
    r? ````@michaelwoerister````
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    ad0be15 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#124609 - RalfJung:float-precision, r=cuviper

    variable-precision float operations can differ depending on optimization levels
    
    Follow-up to rust-lang#121793 and rust-lang#118217 that accounts for optimizations changing the precision of these functions.
    
    Fixes rust-lang#109118
    Fixes rust-lang#71355
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    c412751 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#124610 - nnethercote:typenum, r=lcnr

    Tweak `consts_may_unify`
    
    r? ````@lcnr````
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    a9edd38 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#124626 - RalfJung:const_eval_select, r=joboet

    const_eval_select: add tracking issue
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    e2a5344 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#124637 - fmease:ast-pretty-ty-asc-builtin-s…

    …yn, r=compiler-errors
    
    AST pretty: Use `builtin_syntax` for type ascription
    
    Follow-up to rust-lang#122806.
    CC #124619.
    matthiaskrgr authored May 3, 2024
    Configuration menu
    Copy the full SHA
    e6c82d9 View commit details
    Browse the repository at this point in the history