Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: keep all cargo test files in dist rustc-src #124296

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 23, 2024

Cargo tests use some files that we would otherwise exclude, especially
the cargo init tests that are meant to deal with pre-existing .git
and .hg repos and their ignore files. Keeping these in our dist
tarball doesn't take much space, and allows distro builds to run these
tests successfully.

Cargo tests use some files that we would otherwise exclude, especially
the `cargo init` tests that are meant to deal with pre-existing `.git`
and `.hg` repos and their ignore files. Keeping these in our dist
tarball doesn't take much space, and allows distro builds to run these
tests successfully.
@rustbot
Copy link
Collaborator

rustbot commented Apr 23, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 23, 2024
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2024

📌 Commit 899e3ae has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2024
@bors
Copy link
Contributor

bors commented Apr 26, 2024

⌛ Testing commit 899e3ae with merge aa6a8ee...

@bors
Copy link
Contributor

bors commented Apr 27, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing aa6a8ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2024
@bors bors merged commit aa6a8ee into rust-lang:master Apr 27, 2024
13 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 27, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa6a8ee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.336s -> 673.585s (0.04%)
Artifact size: 315.94 MiB -> 315.93 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants