Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No libc msvc #123938

Closed
wants to merge 6 commits into from
Closed

No libc msvc #123938

wants to merge 6 commits into from

Conversation

ChrisDenton
Copy link
Member

r? ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 14, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin saethlin mentioned this pull request Apr 14, 2024
Merged
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Getting action download info
Download action repository 'msys2/[email protected]' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v4' (SHA:5d5d22a31266ced268874388b861e4b58bb5c2f3)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
Cloning into '/home/runner/work/rust/rust/src/doc/rustc-dev-guide'...
Cloning into '/home/runner/work/rust/rust/src/doc/book'...
Cloning into '/home/runner/work/rust/rust/src/tools/cargo'...
Submodule path 'library/backtrace': checked out 'e15130618237eb3e2d4b622549f9647b4c1d9ca3'
fatal: remote error: upload-pack: not our ref 5bcf5751f608d8d8d8cf539a04f730af81f887a1
fatal: Fetched in submodule path 'library/stdarch', but it did not contain 5bcf5751f608d8d8d8cf539a04f730af81f887a1. Direct fetching of that commit failed.
Cleared directory 'library/backtrace'
Submodule 'library/backtrace' (https://github.com/rust-lang/backtrace-rs.git) unregistered for path 'library/backtrace'
Cleared directory 'library/stdarch'
Submodule 'library/stdarch' (https://github.com/rust-lang/stdarch.git) unregistered for path 'library/stdarch'
---
Submodule 'src/doc/rustc-dev-guide' (https://github.com/rust-lang/rustc-dev-guide.git) registered for path 'src/doc/rustc-dev-guide'
Submodule 'src/llvm-project' (https://github.com/rust-lang/llvm-project.git) registered for path 'src/llvm-project'
Submodule 'src/tools/cargo' (https://github.com/rust-lang/cargo.git) registered for path 'src/tools/cargo'
Submodule path 'library/backtrace': checked out 'e15130618237eb3e2d4b622549f9647b4c1d9ca3'
fatal: remote error: upload-pack: not our ref 5bcf5751f608d8d8d8cf539a04f730af81f887a1
fatal: Fetched in submodule path 'library/stdarch', but it did not contain 5bcf5751f608d8d8d8cf539a04f730af81f887a1. Direct fetching of that commit failed.
Cleared directory 'library/backtrace'
Submodule 'library/backtrace' (https://github.com/rust-lang/backtrace-rs.git) unregistered for path 'library/backtrace'
Cleared directory 'library/stdarch'
Submodule 'library/stdarch' (https://github.com/rust-lang/stdarch.git) unregistered for path 'library/stdarch'
---
Submodule 'src/doc/rustc-dev-guide' (https://github.com/rust-lang/rustc-dev-guide.git) registered for path 'src/doc/rustc-dev-guide'
Submodule 'src/llvm-project' (https://github.com/rust-lang/llvm-project.git) registered for path 'src/llvm-project'
Submodule 'src/tools/cargo' (https://github.com/rust-lang/cargo.git) registered for path 'src/tools/cargo'
Submodule path 'library/backtrace': checked out 'e15130618237eb3e2d4b622549f9647b4c1d9ca3'
fatal: remote error: upload-pack: not our ref 5bcf5751f608d8d8d8cf539a04f730af81f887a1
fatal: Fetched in submodule path 'library/stdarch', but it did not contain 5bcf5751f608d8d8d8cf539a04f730af81f887a1. Direct fetching of that commit failed.
Cleared directory 'library/backtrace'
Submodule 'library/backtrace' (https://github.com/rust-lang/backtrace-rs.git) unregistered for path 'library/backtrace'
Cleared directory 'library/stdarch'
Submodule 'library/stdarch' (https://github.com/rust-lang/stdarch.git) unregistered for path 'library/stdarch'
---
Submodule 'src/doc/rustc-dev-guide' (https://github.com/rust-lang/rustc-dev-guide.git) registered for path 'src/doc/rustc-dev-guide'
Submodule 'src/llvm-project' (https://github.com/rust-lang/llvm-project.git) registered for path 'src/llvm-project'
Submodule 'src/tools/cargo' (https://github.com/rust-lang/cargo.git) registered for path 'src/tools/cargo'
Submodule path 'library/backtrace': checked out 'e15130618237eb3e2d4b622549f9647b4c1d9ca3'
fatal: remote error: upload-pack: not our ref 5bcf5751f608d8d8d8cf539a04f730af81f887a1
fatal: Fetched in submodule path 'library/stdarch', but it did not contain 5bcf5751f608d8d8d8cf539a04f730af81f887a1. Direct fetching of that commit failed.
Cleared directory 'library/backtrace'
Submodule 'library/backtrace' (https://github.com/rust-lang/backtrace-rs.git) unregistered for path 'library/backtrace'
Cleared directory 'library/stdarch'
Submodule 'library/stdarch' (https://github.com/rust-lang/stdarch.git) unregistered for path 'library/stdarch'
---
Submodule 'src/doc/rustc-dev-guide' (https://github.com/rust-lang/rustc-dev-guide.git) registered for path 'src/doc/rustc-dev-guide'
Submodule 'src/llvm-project' (https://github.com/rust-lang/llvm-project.git) registered for path 'src/llvm-project'
Submodule 'src/tools/cargo' (https://github.com/rust-lang/cargo.git) registered for path 'src/tools/cargo'
Submodule path 'library/backtrace': checked out 'e15130618237eb3e2d4b622549f9647b4c1d9ca3'
fatal: remote error: upload-pack: not our ref 5bcf5751f608d8d8d8cf539a04f730af81f887a1
fatal: Fetched in submodule path 'library/stdarch', but it did not contain 5bcf5751f608d8d8d8cf539a04f730af81f887a1. Direct fetching of that commit failed.
##[error]Process completed with exit code 1.
Post job cleanup.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 15, 2024
@compiler-errors
Rollup merge of rust-lang#123943 - saethlin:less-sysroot-libc, r=work…
89e55f7 
…ingjubilee

Use the rustc_private libc less in tests

I started looking into our use of `rustc_private` + `extern crate libc;` in tests because of rust-lang#123938 and it looks like some fraction of the users of libc simply don't need the libc crate anymore.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2024
@rust-timer
Unrolled build for rust-lang#123943
bc23836 
Rollup merge of rust-lang#123943 - saethlin:less-sysroot-libc, r=workingjubilee

Use the rustc_private libc less in tests

I started looking into our use of `rustc_private` + `extern crate libc;` in tests because of rust-lang#123938 and it looks like some fraction of the users of libc simply don't need the libc crate anymore.
@saethlin saethlin mentioned this pull request Apr 17, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 18, 2024
@matthiaskrgr
Rollup merge of rust-lang#124072 - saethlin:less-sysroot-libc-misc, r…
458adfc 
…=jieyouxu

Remove libc from more tests

The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang#123938 more plausible.

This PR is a few simple cases that I missed in rust-lang#123943.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
@bors
Auto merge of rust-lang#124072 - saethlin:less-sysroot-libc-misc, r=j…
0e15f5e 
…ieyouxu

Remove libc from more tests

The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang#123938 more plausible.

This PR is a few simple cases that I missed in rust-lang#123943.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 19, 2024
@bors
Auto merge of #124072 - saethlin:less-sysroot-libc-misc, r=jieyouxu
084a337 
Remove libc from more tests

The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang/rust#123938 more plausible.

This PR is a few simple cases that I missed in rust-lang/rust#123943.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisDenton @rust-log-analyzer @rustbot @saethlin