Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] Prepare Rust 1.77.2 #123681

Merged
merged 6 commits into from
Apr 9, 2024
Merged

[stable] Prepare Rust 1.77.2 #123681

merged 6 commits into from
Apr 9, 2024

Conversation

pietroalbini
Copy link
Member

ChrisDenton and others added 5 commits April 9, 2024 01:09
@ChrisDenton @pietroalbini
Disallow or quote all specials in bat args
f6870bd
@ChrisDenton @pietroalbini
Document Windows argument splitting
ad13f26
@Noratrieb @pietroalbini
Update ninja on Windows
2777517 
Errors started showing up, and I read somewhere that this might be
because of old ninja versions. This ninja version is indeed *ancient*.

```
multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
```
@pietroalbini
update release notes
5babeca
@pietroalbini
bump version to 1.77.2
664d122
@rustbot
Copy link
Collaborator

rustbot commented Apr 9, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@pietroalbini
Copy link
Member Author

@bors r+ p=1000 rollup=never

@rustbot
Copy link
Collaborator

rustbot commented Apr 9, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Apr 9, 2024
@bors
Copy link
Contributor

bors commented Apr 9, 2024

📌 Commit 664d122 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2024
@bors
Copy link
Contributor

bors commented Apr 9, 2024

⌛ Testing commit 664d122 with merge 95f2dd0...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
@bors
Auto merge of rust-lang#123681 - pietroalbini:pa-cve-2024-24576-stabl…
95f2dd0 
…e, r=pietroalbini

[stable] Prepare Rust 1.77.2

See https://blog.rust-lang.org/2024/04/09/cve-2024-24576.html
@bors
Copy link
Contributor

bors commented Apr 9, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2024
@cuviper
Copy link
Member

cuviper commented Apr 9, 2024 

tidy error: file /checkout/tests/ui/std/windows-bat-args2.bat has unexpected extension bat
tidy error: file /checkout/tests/ui/std/windows-bat-args1.bat has unexpected extension bat
tidy error: file /checkout/tests/ui/std/windows-bat-args3.bat has unexpected extension bat

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 9, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pietroalbini
Copy link
Member Author

Fixed the tidy issue. Will now cherry pick it into the other branches.

@bors r+ p=1000 rollup=never

@bors
Copy link
Contributor

bors commented Apr 9, 2024

📌 Commit e7b09f5 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2024
This was referenced Apr 9, 2024
Merged
Merged
@bors
Copy link
Contributor

bors commented Apr 9, 2024

⌛ Testing commit e7b09f5 with merge 25ef9e3...

@bors
Copy link
Contributor

bors commented Apr 9, 2024

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 25ef9e3 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 9, 2024
@bors bors merged commit 25ef9e3 into rust-lang:stable Apr 9, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.2 milestone Apr 9, 2024
@pietroalbini pietroalbini deleted the pa-cve-2024-24576-stable branch April 9, 2024 20:10
@straight-shoota straight-shoota mentioned this pull request Apr 24, 2024
Closed
@fmease fmease mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.2
Development

Successfully merging this pull request may close these issues.
8 participants
@pietroalbini @rustbot @bors @cuviper @rust-log-analyzer @joboet @ChrisDenton @Noratrieb