-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiletest: properly handle revisioned run-rustfix tests #123601
compiletest: properly handle revisioned run-rustfix tests #123601
Conversation
d042ee9
to
de3857e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
r? WaffleLapkin
r=me with green CI
☀️ Test successful - checks-actions |
Finished benchmarking commit (9d5cdf7): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.569s -> 665.855s (-0.26%) |
Before this PR, if you have a revisioned
//@ run-rustfix
test like//@[foo] run-rustfix
, you would run into an error saying crate name cannot contain.
characters because the fixed test file trying to be compiled is named<test-name>.<revision>.fixed
, from whichrustc
infers the crate name to be<test-name>.<revision>
which is not a valid crate name.This PR fixes the problem by constructing a synthetic crate name from
<test-name>.<revision>
, by-
with_
, and.
with__
and pass that constructed crate name with
--crate-name
to rustc to compile the fixed file.Fixes #123596.