Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: update pulldown-cmark to 0.10 #123013

Closed

Conversation

stepantubanov
Copy link

Updated from 0.9 to 0.10.

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2024

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@GuillaumeGomez
Copy link
Member

cc @notriddle

@rust-log-analyzer

This comment has been minimized.

@notriddle
Copy link
Contributor

notriddle commented Mar 24, 2024

I don’t think we can merge this yet.

pulldown-cmark/pulldown-cmark#864 has not been released yet. It could also use a lint to mitigate some of the other regressions found in #121659

@stepantubanov
Copy link
Author

@notriddle I see, that makes sense, thanks! Should I close this or keep it open until we can update?

@stepantubanov stepantubanov force-pushed the update-pulldown-cmark branch from c3d3e1d to b0632d2 Compare March 24, 2024 23:08
@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Mar 25, 2024

☔ The latest upstream changes (presumably #122968) made this pull request unmergeable. Please resolve the merge conflicts.

@stepantubanov stepantubanov marked this pull request as draft March 25, 2024 13:14
@Dylan-DPC
Copy link
Member

@stepantubanov if you can resolve the conflict with the lock file and mark this as ready for review we can push this further

@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2024
@stepantubanov stepantubanov force-pushed the update-pulldown-cmark branch from b0632d2 to 7415e4d Compare May 4, 2024 18:14
@stepantubanov stepantubanov marked this pull request as ready for review May 4, 2024 19:35
@bors
Copy link
Contributor

bors commented May 11, 2024

☔ The latest upstream changes (presumably #124213) made this pull request unmergeable. Please resolve the merge conflicts.

@notriddle
Copy link
Contributor

#127127 makes this outdated.

@notriddle notriddle closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants