-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling up PRs in the queue #12221
Closed
Closed
Rolling up PRs in the queue #12221
Commits on Feb 12, 2014
-
Stop unloading syntax libraries
Externally loaded libraries are able to do things that cause references to them to survive past the expansion phase (e.g. creating @-box cycles, launching a task or storing something in task local data). As such, the library has to stay loaded for the lifetime of the process.
Configuration menu - View commit details
-
Copy full SHA for 4e9724d - Browse repository at this point
Copy the full SHA 4e9724dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9058e0 - Browse repository at this point
Copy the full SHA e9058e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb595cd - Browse repository at this point
Copy the full SHA fb595cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a56430 - Browse repository at this point
Copy the full SHA 7a56430View commit details -
Remove a source of O(n^2) running time in bigints.
::num::bigint, Remove a source of O(n^2) running time in `fn shr_bits`. I'll cut to the chase: On my laptop, this brings the running time on `pidigits 2000` (from src/test/bench/shootout-pidigits.rs) from this: ``` % time ./pidigits 2000 > /dev/null real 0m7.695s user 0m7.690s sys 0m0.005s ``` to this: ``` % time ./pidigits 2000 > /dev/null real 0m0.322s user 0m0.318s sys 0m0.004s ``` The previous code was building up a vector by repeatedly making a fresh copy for each element that was unshifted onto the front, yielding quadratic running time. This fixes that by building up the vector in reverse order (pushing elements onto the end) and then reversing it. (Another option would be to build up a zero-initialized vector of the desired length and then installing all of the shifted result elements into their target index, but this was easier to hack up quickly, and yields the desired asymptotic improvement. I have been thinking of adding a `vec::from_fn_rev` to handle this case, maybe I will try that this weekend.)
Configuration menu - View commit details
-
Copy full SHA for cdc3843 - Browse repository at this point
Copy the full SHA cdc3843View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6436917 - Browse repository at this point
Copy the full SHA 6436917View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ec3027 - Browse repository at this point
Copy the full SHA 2ec3027View commit details
Commits on Feb 13, 2014
-
4
Configuration menu - View commit details
-
Copy full SHA for 3857604 - Browse repository at this point
Copy the full SHA 3857604View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.