Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test wasm32-wasip1 in CI, not wasm32-unknown-unknown #122036

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Test wasm32-wasip1 in CI, not wasm32-unknown-unknown #122036

merged 7 commits into from
Mar 12, 2024

Commits on Mar 11, 2024

  1. Convert some WebAssembly run-make tests to Rust 

    This commit rewrites a number of `run-make` tests centered around wasm
to instead use `rmake.rs` and additionally use the `wasm32-wasip1`
target instead of `wasm32-unknown-unknown`. Testing no longer requires
Node.js and additionally uses the `wasmparser` crate from crates.io to
parse outputs and power assertions.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7141379 View commit details
    Browse the repository at this point in the history

  2. libtest: Print timing information on WASI 

    This commit updates the libtest conditionals to use `std::time::Instant`
on WASI targets where it's implemented. Previously all wasm targets
wouldn't use this type.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    8fcc009 View commit details
    Browse the repository at this point in the history

  3. Remove old support for emscripten/wasm32-u-u 

    This commit removes the `wasm32-shim.js` file, for example, and deletes
old support for Emscripten which hasn't been exercised in some time.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7d9690a View commit details
    Browse the repository at this point in the history

  4. Configure a default runner for WASI targets 

    If one is not explicitly configured look in the system environment to
try and find one. For now just probing for `wasmtime` is implemented.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    341215c View commit details
    Browse the repository at this point in the history

  5. Update test-various docker image to test wasm32-wasip1 

    Drop testing of `wasm32-unknown-unknown` and instead only test a WASI
target which enables more debugging utilities such as printing.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    fc746c8 View commit details
    Browse the repository at this point in the history

  6. compiletest: Automatically compare output by subset with runners 

    This commit updates compiletest to automatically compare test output
with subsets if a `--runner` argument is configured. Runners might
inject extra information on failures, for example a WebAssembly runtime
printing a wasm stack trace, which won't be in the output of a native
runtime. The output with a `--runner` argument, however, should still
have all the native output present.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4a5aa1a View commit details
    Browse the repository at this point in the history

  7. Update test directives for wasm32-wasip1 

    * The WASI targets deal with the `main` symbol a bit differently than
  native so some `codegen` and `assembly` tests have been ignored.
* All `ignore-emscripten` directives have been updated to
  `ignore-wasm32` to be more clear that all wasm targets are ignored and
  it's not just Emscripten.
* Most `ignore-wasm32-bare` directives are now gone.
* Some ignore directives for wasm were switched to `needs-unwind`
  instead.
* Many `ignore-wasm32*` directives are removed as the tests work with
  WASI as opposed to `wasm32-unknown-unknown`.
    @alexcrichton
    alexcrichton committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cf6d605 View commit details
    Browse the repository at this point in the history