Issue 6801 borrowck closures #12158
Merged
Issue 6801 borrowck closures #12158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent 1.0 progress. A thousand r+'s from me. |
|
Gonna get to this after dinner. |
|
Overall the logic looks correct as far as I can tell, although I obviously haven't proved it to myself. Just had some minor style nits. r=me when done. |
|
Does this also close #11302? |
This was referenced Feb 11, 2014
…ing mutable borrows
…d to be mutably shared between them both
…refs as deref'd borrowed pointers
|
Fixes #11302. |
lifthrasiir
added a commit
to lifthrasiir/angolmois-rust
that referenced
this pull request
Feb 12, 2014
lifthrasiir
added a commit
to snrs/sonorous
that referenced
this pull request
Feb 14, 2014
- the parser is now based on the iterator interface (finally), which returns a combined parsed item. - the parsed item includes Encoding, that eliminates the need of the BmsUsesEncoding special message. - the player has some more methods refactored out of the tick method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I factored the commits by affected files, for the most part. The last 7 or 8 contain the meat of the PR. The rest are small changes to closures found in the codebase. Maybe interesting to read to see some of the impact of the rules.
r? @pcwalton
Fixes #6801