Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider middle segments of paths in unused_qualifications #121528

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Consider middle segments of paths in unused_qualifications #121528

merged 1 commit into from
Mar 4, 2024

Conversation

Alexendoo
Copy link
Member

Currently unused_qualifications looks at the last segment of a path to see if it can be trimmed, this PR extends the check to the middle segments also

// currently linted
use std::env::args();
std::env::args(); // Removes `std::env::`
// newly linted
use std::env;
std::env::args(); // Removes `std::`

Paths with generics in them are now linted as long as the part being trimmed is before any generic args, e.g. it will now suggest trimming std::vec:: from std::vec::Vec<usize>

Paths with any segments that are from an expansion are no longer linted

Fixes #100979
Fixes #96698

@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2024
@lcnr
Copy link
Contributor

lcnr commented Feb 26, 2024

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned lcnr Feb 26, 2024
petrochenkov
petrochenkov reviewed Mar 1, 2024
View reviewed changes
tests/ui/lint/lint-qualification.rs Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024
@petrochenkov
Copy link
Contributor

r=me with #121528 (comment) addressed.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2024

📌 Commit 4ea9f72 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2024
@bors
Auto merge of rust-lang#121955 - matthiaskrgr:rollup-1i3lo0j, r=matth…
3fb9000 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#121248 (Move some tests)
 - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`)
 - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names)
 - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr)
 - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2024
@bors
Auto merge of rust-lang#121955 - matthiaskrgr:rollup-1i3lo0j, r=matth…
89b7830 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#121248 (Move some tests)
 - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`)
 - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names)
 - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr)
 - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed6d175 into rust-lang:master Mar 4, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2024
@rust-timer
Unrolled build for rust-lang#121528
f6ee0c0 
Rollup merge of rust-lang#121528 - Alexendoo:unused_qualifications, r=petrochenkov

Consider middle segments of paths in `unused_qualifications`

Currently `unused_qualifications` looks at the last segment of a path to see if it can be trimmed, this PR extends the check to the middle segments also

```rust
// currently linted
use std::env::args();
std::env::args(); // Removes `std::env::`
```
```rust
// newly linted
use std::env;
std::env::args(); // Removes `std::`
```

Paths with generics in them are now linted as long as the part being trimmed is before any generic args, e.g. it will now suggest trimming `std::vec::` from `std::vec::Vec<usize>`

Paths with any segments that are from an expansion are no longer linted

Fixes rust-lang#100979
Fixes rust-lang#96698
@Alexendoo Alexendoo deleted the unused_qualifications branch March 4, 2024 13:19
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 4, 2024
Closed
@apiraino apiraino mentioned this pull request Mar 15, 2024
Open
@dtolnay dtolnay mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
5 participants
@Alexendoo @rustbot @lcnr @petrochenkov @bors