never patterns: Fix liveness analysis in the presence of never patterns #121391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
5 tasks
compiler-errors
approved these changes
Feb 21, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
Thank u! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 21, 2024
…-errors never patterns: Fix liveness analysis in the presence of never patterns There's a bunch of code that only looks at the first alternative of an or-pattern, under the assumption that all alternatives have the same set of bindings. This is true except for never pattern alternatives (e.g. `Ok(x) | Err(!)`), so we skip these. I expect there's other code with this problem, I'll have to check that later. I don't have tests for this yet because mir lowering causes other issues; I'll have some in the next PR. r? `@compiler-errors`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#119636 (os::net: expanding TcpStreamExt for Linux with `tcp_deferaccept`.) - rust-lang#121261 (coverage: Remove `pending_dups` from the span refiner) - rust-lang#121336 (triagebot: add queue notifications) - rust-lang#121391 (never patterns: Fix liveness analysis in the presence of never patterns) - rust-lang#121399 (Solaris linker does not support --strip-debug) - rust-lang#121406 (Add a couple tests) Failed merges: - rust-lang#121206 (Top level error handling) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#121206 (Top level error handling) - rust-lang#121261 (coverage: Remove `pending_dups` from the span refiner) - rust-lang#121336 (triagebot: add queue notifications) - rust-lang#121373 (Consistently refer to a test's `revision` instead of `cfg`) - rust-lang#121391 (never patterns: Fix liveness analysis in the presence of never patterns) - rust-lang#121392 (Unify dylib loading between proc macros and codegen backends) - rust-lang#121399 (Solaris linker does not support --strip-debug) - rust-lang#121406 (Add a couple tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2024
Rollup merge of rust-lang#121391 - Nadrieril:fix-liveness, r=compiler-errors never patterns: Fix liveness analysis in the presence of never patterns There's a bunch of code that only looks at the first alternative of an or-pattern, under the assumption that all alternatives have the same set of bindings. This is true except for never pattern alternatives (e.g. `Ok(x) | Err(!)`), so we skip these. I expect there's other code with this problem, I'll have to check that later. I don't have tests for this yet because mir lowering causes other issues; I'll have some in the next PR. r? ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of code that only looks at the first alternative of an or-pattern, under the assumption that all alternatives have the same set of bindings. This is true except for never pattern alternatives (e.g.
Ok(x) | Err(!)), so we skip these. I expect there's other code with this problem, I'll have to check that later.I don't have tests for this yet because mir lowering causes other issues; I'll have some in the next PR.
r? @compiler-errors