-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #121320
Rollup of 8 pull requests #121320
Commits on Feb 16, 2024
-
Merge
CompilerError::CompilationFailed
andCompilerError::ICE
.`CompilerError` has `CompilationFailed` and `ICE` variants, which seems reasonable at first. But the way it identifies them is flawed: - If compilation errors out, i.e. `RunCompiler::run` returns an `Err`, it uses `CompilationFailed`, which is reasonable. - If compilation panics with `FatalError`, it catches the panic and uses `ICE`. This is sometimes right, because ICEs do cause `FatalError` panics, but sometimes wrong, because certain compiler errors also cause `FatalError` panics. (The compiler/rustdoc/clippy/whatever just catches the `FatalError` with `catch_with_exit_code` in `main`.) In other words, certain non-ICE compilation failures get miscategorized as ICEs. It's not possible to reliably distinguish the two cases, so this commit merges them. It also renames the combined variant as just `Failed`, to better match the existing `Interrupted` and `Skipped` variants. Here is an example of a non-ICE failure that causes a `FatalError` panic, from `tests/ui/recursion_limit/issue-105700.rs`: ``` #![recursion_limit="4"] #![invalid_attribute] #![invalid_attribute] #![invalid_attribute] #![invalid_attribute] #![invalid_attribute] //~^ERROR recursion limit reached while expanding fn main() {{}} ```
Configuration menu - View commit details
-
Copy full SHA for e72e7e9 - Browse repository at this point
Copy the full SHA e72e7e9View commit details
Commits on Feb 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 488ffaa - Browse repository at this point
Copy the full SHA 488ffaaView commit details -
Move the extra directives for
Mode::CoverageRun
intoiter_header
When these extra directives were ported over as part of rust-lang#112300, it made sense to introduce `iter_header_extra` and pass them in as an extra argument. But now that rust-lang#120881 has added a `mode` parameter to `iter_header` for its own purposes, it's slightly simpler to move the coverage special-case code directly into `iter_header` as well. This lets us get rid of `iter_header_extra`.
Configuration menu - View commit details
-
Copy full SHA for c521d7f - Browse repository at this point
Copy the full SHA c521d7fView commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 864cee3 - Browse repository at this point
Copy the full SHA 864cee3View commit details
Commits on Feb 19, 2024
-
Drive-by
DUMMY_SP
->Span
and fmt changesNoticed these while doing something else. There's no practical change, but it's preferable to use `DUMMY_SP` as little as possible, particularly when we have perfectlly useful `Span`s available.
Configuration menu - View commit details
-
Copy full SHA for b4a424f - Browse repository at this point
Copy the full SHA b4a424fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac1754b - Browse repository at this point
Copy the full SHA ac1754bView commit details -
Make
is_nonoverlapping
#[inline]
It showed up with 3% execution time in a compiler profile.
Configuration menu - View commit details
-
Copy full SHA for 0b59748 - Browse repository at this point
Copy the full SHA 0b59748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e5ad42 - Browse repository at this point
Copy the full SHA 3e5ad42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41fddb5 - Browse repository at this point
Copy the full SHA 41fddb5View commit details
Commits on Feb 20, 2024
-
Rollup merge of rust-lang#120718 - saethlin:reasonable-fast-math, r=n…
…nethercote Add "algebraic" fast-math intrinsics, based on fast-math ops that cannot return poison Setting all of LLVM's fast-math flags makes our fast-math intrinsics very dangerous, because some inputs are UB. This set of flags permits common algebraic transformations, but according to the [LangRef](https://llvm.org/docs/LangRef.html#fastmath), only the flags `nnan` (no nans) and `ninf` (no infs) can produce poison. And this uses the algebraic float ops to fix rust-lang#120720 cc `@orlp`
Configuration menu - View commit details
-
Copy full SHA for 5692324 - Browse repository at this point
Copy the full SHA 5692324View commit details -
Rollup merge of rust-lang#121195 - D0liphin:master, r=ehuss
unstable-book: Separate testing and production sanitizers This is a redo of [this PR](rust-lang#108942). Left the commit as before (except for reflowing to 80-width), since it already got approved.
Configuration menu - View commit details
-
Copy full SHA for bbe1fad - Browse repository at this point
Copy the full SHA bbe1fadView commit details -
Rollup merge of rust-lang#121205 - nnethercote:fix-stable-mir-Compile…
…rError, r=oli-obk Merge `CompilerError::CompilationFailed` and `CompilerError::ICE`. `CompilerError` has `CompilationFailed` and `ICE` variants, which seems reasonable at first. But the way it identifies them is flawed: - If compilation errors out, i.e. `RunCompiler::run` returns an `Err`, it uses `CompilationFailed`, which is reasonable. - If compilation panics with `FatalError`, it catches the panic and uses `ICE`. This is sometimes right, because ICEs do cause `FatalError` panics, but sometimes wrong, because certain compiler errors also cause `FatalError` panics. (The compiler/rustdoc/clippy/whatever just catches the `FatalError` with `catch_with_exit_code` in `main`.) In other words, certain non-ICE compilation failures get miscategorized as ICEs. It's not possible to reliably distinguish the two cases, so this commit merges them. It also renames the combined variant as just `Failed`, to better match the existing `Interrupted` and `Skipped` variants. Here is an example of a non-ICE failure that causes a `FatalError` panic, from `tests/ui/recursion_limit/issue-105700.rs`: ``` #![recursion_limit="4"] #![invalid_attribute] #![invalid_attribute] #![invalid_attribute] #![invalid_attribute] #![invalid_attribute] //~^ERROR recursion limit reached while expanding fn main() {{}} ``` r? `@spastorino`
Configuration menu - View commit details
-
Copy full SHA for 5acf646 - Browse repository at this point
Copy the full SHA 5acf646View commit details -
Rollup merge of rust-lang#121233 - Zalathar:extra-directives, r=oli-obk
Move the extra directives for `Mode::CoverageRun` into `iter_header` When these extra directives were ported over as part of rust-lang#112300, it made sense to introduce `iter_header_extra` and pass them in as an extra argument. But now that rust-lang#120881 has added a `mode` parameter to `iter_header` for its own purposes, it's slightly simpler to move the coverage special-case code directly into `iter_header` as well. This lets us get rid of `iter_header_extra`.
Configuration menu - View commit details
-
Copy full SHA for 5c14f75 - Browse repository at this point
Copy the full SHA 5c14f75View commit details -
Rollup merge of rust-lang#121256 - Jarcho:visitor2, r=oli-obk
Allow AST and HIR visitors to return `ControlFlow` Alternative to rust-lang#108598. Since rust-lang/libs-team#187 was rejected, this implements our own version of the `Try` trait (`VisitorResult`) and the `try` macro (`try_visit`). Since this change still allows visitors to return `()`, no changes have been made to the existing ones. They can be done in a separate PR.
Configuration menu - View commit details
-
Copy full SHA for ef2b714 - Browse repository at this point
Copy the full SHA ef2b714View commit details -
Rollup merge of rust-lang#121307 - estebank:drive-by, r=compiler-errors
Drive-by `DUMMY_SP` -> `Span` and fmt changes Noticed these while doing something else. There's no practical change, but it's preferable to use `DUMMY_SP` as little as possible, particularly when we have perfectlly useful `Span`s available.
Configuration menu - View commit details
-
Copy full SHA for 8fe828e - Browse repository at this point
Copy the full SHA 8fe828eView commit details -
Rollup merge of rust-lang#121310 - GrigorenkoPV:doc-smallfix, r=Nilst…
…rieb Remove an old hack for rustdoc Since rust-lang#78696 has been resolved
Configuration menu - View commit details
-
Copy full SHA for e6060eb - Browse repository at this point
Copy the full SHA e6060ebView commit details -
Rollup merge of rust-lang#121311 - Nilstrieb:is-it-overlapping, r=sae…
…thlin Make `is_nonoverlapping` `#[inline]` It showed up with 3% execution time in a compiler profile. backlink to rust-lang#120848 r? `@saethlin`
Configuration menu - View commit details
-
Copy full SHA for 6544ba2 - Browse repository at this point
Copy the full SHA 6544ba2View commit details