-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust.frame-pointers
config option
#121203
Conversation
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
Can you make this on by default in the compiler profile? |
r=me on this change with or without the compiler profile change |
This is very helpful for profiling. I've hacked this in many times, so let's add it properly.
This PR changes src/bootstrap/defaults/config.compiler.toml. If appropriate, please also update This PR modifies If appropriate, please update This PR changes src/bootstrap/defaults/config.codegen.toml. If appropriate, please also update |
with :3 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (eb1f279): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 640.916s -> 641.205s (0.05%) |
Fix LVI tests after frame pointers are enabled by default rust-lang#121203 enables frame pointers by default. This affects LVI mitigations for the `x86_64-fortanix-unknown-sgx` target. LVI remained mitigated correctly, but the tests were too strict. `@nshyrei` , `@jethrogb`
Fix LVI tests after frame pointers are enabled by default rust-lang#121203 enables frame pointers by default. This affects LVI mitigations for the `x86_64-fortanix-unknown-sgx` target. LVI remained mitigated correctly, but the tests were too strict. ``@nshyrei`` , ``@jethrogb``
Rollup merge of rust-lang#121683 - fortanix:raoul/lvi_fixes, r=cuviper Fix LVI tests after frame pointers are enabled by default rust-lang#121203 enables frame pointers by default. This affects LVI mitigations for the `x86_64-fortanix-unknown-sgx` target. LVI remained mitigated correctly, but the tests were too strict. ``@nshyrei`` , ``@jethrogb``
This is very helpful for profiling. I've hacked this in many times, so let's add it properly.