match lowering: test one or pattern at a time #121175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I wanna iron this out, I did something weird with the @rustbot author |
rustbot
added
S-waiting-on-author
Nadrieril
force-pushed
the
simplify-or-selection
branch
from
575327b
to
3cbd4de
Compare
|
Fixed it @rustbot ready |
rustbot
added
S-waiting-on-review
Nadrieril
force-pushed
the
simplify-or-selection
branch
from
3cbd4de
to
806ee5f
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
Nadrieril
force-pushed
the
simplify-or-selection
branch
2 times, most recently
from
95b968e
to
e712fb6
Compare
|
Oops, raced you, I was rebasing on top of master. Will restart when CI is green, commits are identical @bors r- |
bors
added
S-waiting-on-author
This comment was marked as resolved.
This comment was marked as resolved.
Nadrieril
force-pushed
the
simplify-or-selection
branch
from
e712fb6
to
c1514a6
Compare
|
(identical except for a @bors r=matthewjasper |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#121044 (Support async trait bounds in macros) - rust-lang#121175 (match lowering: test one or pattern at a time) - rust-lang#121340 (bootstrap: apply most of clippy's suggestions) - rust-lang#121347 (compiletest: support auxiliaries with auxiliaries) - rust-lang#121359 (miscellaneous type system improvements) - rust-lang#121366 (Remove `diagnostic_builder.rs`) - rust-lang#121379 (Remove an `unchecked_error_guaranteed` call.) - rust-lang#121396 (make it possible for outside crates to inspect a mir::ConstValue with the interpreter) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup merge of rust-lang#121175 - Nadrieril:simplify-or-selection, r=matthewjasper match lowering: test one or pattern at a time This is a bit more opinionated than the previous PRs. On the face of it this is less efficient and more complex than before, but I personally found the loop that digs into `leaf_candidates` on each iteration very confusing. Instead this does "generate code for this or-pattern" then "generate further code for each branch if needed" in two steps. Incidentally this way we don't _require_ or patterns to be sorted at the end. It's still an important optimization but I find it clearer to not rely on it for correctness. r? `@matthewjasper`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit more opinionated than the previous PRs. On the face of it this is less efficient and more complex than before, but I personally found the loop that digs into
leaf_candidateson each iteration very confusing. Instead this does "generate code for this or-pattern" then "generate further code for each branch if needed" in two steps.Incidentally this way we don't require or patterns to be sorted at the end. It's still an important optimization but I find it clearer to not rely on it for correctness.
r? @matthewjasper