Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASCII fast-path for char::is_grapheme_extended #121138

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add ASCII fast-path for char::is_grapheme_extended #121138

merged 1 commit into from
Mar 5, 2024

Commits on Feb 15, 2024

  1. Add ASCII fast-path for char::is_grapheme_extended 

    I discovered that `impl Debug for str` is quite slow because it ends up doing a `unicode_data::grapheme_extend::lookup` for each char, which ends up doing a binary search.

This introduces a fast-path for ASCII chars which do not have this property.

The `lookup` is thus completely gone from profiles.
    @Swatinem
    Swatinem committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8eaaa6e View commit details
    Browse the repository at this point in the history