Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change xfail directives in compiletests to ignore, closes #11363 #12110

Merged
merged 1 commit into from
Feb 11, 2014
Merged

Change xfail directives in compiletests to ignore, closes #11363 #12110

merged 1 commit into from
Feb 11, 2014

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Feb 8, 2014

Patch for #11363

@alexcrichton
Copy link
Member

Amazing work, thank you!

While you're at it, do you want to tackle things like xfail-android as well?

@fhahn
Copy link
Contributor Author

fhahn commented Feb 9, 2014

I've updated the commit and replaced all instances of xfail.

dguenther
dguenther reviewed Feb 10, 2014
View reviewed changes
src/test/compile-fail/vec-add.rs

// FIXME (Issue #2711): + should allow immutable or mutable vectors on
// the right hand side in all cases. We are getting compiler errors
// about this now, so I'm xfailing the test for now. -eholk
// about this now, so I'm ignoreing the test for now. -eholk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a big deal, but could you change this to 'ignoring'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've pushed an updated commit

@fhahn
Copy link
Contributor Author

fhahn commented Feb 10, 2014

I've pushed an updated version of the commit, which updates some tests with xfail that were added yesterday or so. I've change the CHECK_XFAILS variable to CHECK_IGNORED as well. After this PR gets merged, I'm going to update the note about the test suite in the wiki (https://github.com/mozilla/rust/wiki/Note-testsuite).

@dguenther
Copy link
Contributor

This is great, thanks for the work!

@alexcrichton
Copy link
Member

Ah it seems a xfail-pretty snuck in and needs to get update. Feel free to comment on a rebase and I'll r+

@fhahn
Copy link
Contributor Author

fhahn commented Feb 11, 2014

I've pushed an updated commit

bors added a commit that referenced this pull request Feb 11, 2014
@bors
auto merge of #12110 : fhahn/rust/issue-11363-change-xfail, r=alexcri…
4c967e7 
…chton

Patch for #11363
@bors bors closed this Feb 11, 2014
@bors bors merged commit f62460c into rust-lang:master Feb 11, 2014
@fhahn fhahn deleted the issue-11363-change-xfail branch February 11, 2014 22:57
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
@bors
Auto merge of rust-lang#12110 - jonas-schievink:inline-self-type, r=j…
339a186 
…onas-schievink

feat: Make "inline type alias" work for `Self`

Fixes rust-lang/rust-analyzer#12109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fhahn @alexcrichton @dguenther @bors