Deduplicate tcx.instance_mir(instance) calls in try_instance_mir
#120778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @michaelwoerister. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
hahah that code is wild, thanks for finding this r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#120590 (Remove unused args from functions) - rust-lang#120750 (No need to take `ImplTraitContext` by ref) - rust-lang#120769 (make future diffs minimal) - rust-lang#120772 (Remove myself from review rotation.) - rust-lang#120775 (Make `min_exhaustive_patterns` match `exhaustive_patterns` better) - rust-lang#120778 (Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`) - rust-lang#120782 (Fix mir pass ICE in the presence of other errors) - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint) - rust-lang#120801 (Avoid ICE in drop recursion check in case of invalid drop impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
Rollup merge of rust-lang#120778 - zetanumbers:refactor_try_instance_mir, r=compiler-errors Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.