Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote OpenHarmony targets to tier 2 #120585

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Promote OpenHarmony targets to tier 2 #120585

merged 1 commit into from
Mar 4, 2024

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Feb 2, 2024

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 2, 2024
davidtwco
davidtwco approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy compliance and rustc book changes look good to me, needs an infra sign-off.

@davidtwco
Copy link
Member

r? infra

@rustbot rustbot assigned shepmaster and unassigned davidtwco Feb 8, 2024
@Amanieu Amanieu mentioned this pull request Feb 11, 2024
Closed
@matlu
Copy link

matlu commented Feb 14, 2024

r? infra

@davidtwco @shepmaster Do you know if anyone from infra is looking at this?

@Amanieu
Copy link
Member Author

Amanieu commented Feb 26, 2024

r? infra

@rustbot rustbot assigned jdno and unassigned shepmaster Feb 26, 2024
@Amanieu
Copy link
Member Author

Amanieu commented Feb 29, 2024

r? Kobzol

@rustbot rustbot assigned Kobzol and unassigned jdno Feb 29, 2024
Kobzol
Kobzol reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good to me (left one comment regarding the Dockerfile). Could you please push a temporary commit that configures this CI workflow for try and run a try build? So that we can see how long it takes and if the workflow works.

src/ci/docker/host-x86_64/dist-ohos/Dockerfile Outdated Show resolved Hide resolved
@Amanieu
Copy link
Member Author

Amanieu commented Mar 1, 2024

@bors try

@bors
Copy link
Contributor

bors commented Mar 1, 2024

⌛ Trying commit a4e4bbc with merge c558740...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#120585 - Amanieu:ohos-tier2, r=<try>
c558740 
Promote OpenHarmony targets to tier 2

MCP: rust-lang/compiler-team#719
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu
Copy link
Member Author

Amanieu commented Mar 1, 2024

@bors try

@bors
Copy link
Contributor

bors commented Mar 1, 2024

⌛ Trying commit de01160 with merge bc8209f...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#120585 - Amanieu:ohos-tier2, r=<try>
bc8209f 
Promote OpenHarmony targets to tier 2

MCP: rust-lang/compiler-team#719
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 1, 2024

☀️ Try build successful - checks-actions
Build commit: bc8209f (bc8209f3e43c5f913da43138ff1e4bc5a2cf82f6)

@Kobzol
Copy link
Contributor

Kobzol commented Mar 1, 2024

~30 minutes, that's fine. Now let's try with cache.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#120585 - Amanieu:ohos-tier2, r=<try>
b21590c 
Promote OpenHarmony targets to tier 2

MCP: rust-lang/compiler-team#719
@bors
Copy link
Contributor

bors commented Mar 1, 2024

⌛ Trying commit de01160 with merge b21590c...

@bors
Copy link
Contributor

bors commented Mar 1, 2024

☀️ Try build successful - checks-actions
Build commit: b21590c (b21590c588a5d87f469c339fff661a2a1be44749)

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 1, 2024

☀️ Try build successful - checks-actions
Build commit: b21590c (b21590c588a5d87f469c339fff661a2a1be44749)

@Kobzol
Copy link
Contributor

Kobzol commented Mar 1, 2024 •
edited
Loading

24 minutes with Docker cached, nice.

LGTM for me, I'll ask in the infra team Zulip if there are any concerns, but I think this should be good to go.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 2, 2024

@Amanieu You can r=me once you remove the temporary commit.

@Amanieu
Copy link
Member Author

Amanieu commented Mar 3, 2024

@bors r=Kobzol

@bors
Copy link
Contributor

bors commented Mar 3, 2024

📌 Commit 5674f06 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024
@bors
Copy link
Contributor

bors commented Mar 4, 2024

⌛ Testing commit 5674f06 with merge 8b1af4c...

@bors
Copy link
Contributor

bors commented Mar 4, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 8b1af4c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2024
@bors bors merged commit 8b1af4c into rust-lang:master Mar 4, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 4, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8b1af4c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.5% [-3.5%, -3.5%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.6% [-3.6%, -3.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.6% [-3.6%, -3.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 643.72s -> 643.294s (-0.07%)
Artifact size: 175.01 MiB -> 175.02 MiB (0.01%)

@matlu matlu mentioned this pull request Mar 6, 2024
Open
@richerfu richerfu mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
10 participants
@Amanieu @davidtwco @matlu @bors @rust-log-analyzer @Kobzol @rust-timer @shepmaster @jdno @rustbot