Replace NonCopyable usage with NoPod #12016
Conversation
|
@huonw r? |
|
|
||
| #[test] | ||
| fn test_replace() { | ||
| let mut x = Some(NonCopyable); |
There was a problem hiding this comment.
Isn't this testing replace, not NonCopyable?
Maybe change the test to something like Some(~"foo").
|
Is it just me, or is "NoPod" less readable than "NonCopyable" ? :( (I guess I did not mind it or notice so much when it was buried in the rest of PR #11768 but here it seems to bother me.) I would have been fine if |
|
@pnkfelix you mean just having a |
|
Also, FWIW, it doesn't bothers me much. TBH! |
|
@flaper87 yes, a field and deleting the destructor is what I meant. (In my earlier comment I had forgotten the current implementation strategy for Anyway I was just voicing my personal taste, I do not care enough about the readability issue here to try to block your change. After all my own taste might change in time. |
stop linting [`blocks_in_conditions`] on `match` with weird attr macro case should fixes: rust-lang#12016 --- changelog: [`blocks_in_conditions`] - fix FP on `match` with weird attr macro This might not be the best solution, as the root cause (i think?) is the `span` of block was incorrectly given by the compiler? I'm open to better solutions
cc #10834