suggest into_iter() when Iterator method called on impl IntoIterator
#119928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
r? compiler |
|
☔ The latest upstream changes (presumably #120722) made this pull request unmergeable. Please resolve the merge conflicts. |
d-sonuga
force-pushed
the
into-iter-sugg
branch
from
e1b722b
to
6581eed
Compare
This comment has been minimized.
This comment has been minimized.
d-sonuga
force-pushed
the
into-iter-sugg
branch
2 times, most recently
from
7b4201d
to
51a9e61
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
requested changes
Feb 12, 2024
Comment on lines
152
to
153
| tcx.def_path_str(trait_pred.trait_ref.def_id) | ||
| == tcx.def_path_str(into_iterator_trait) |
There was a problem hiding this comment.
Why are you using string comparison here? Just compare the def ids directly.
Suggested change
| tcx.def_path_str(trait_pred.trait_ref.def_id) | |
| == tcx.def_path_str(into_iterator_trait) | |
| trait_pred.trait_ref.def_id == into_iterator_trait |
There was a problem hiding this comment.
Actually, you can use is_diagnostic_item
| } | ||
| _ => return false, | ||
| } | ||
| false |
There was a problem hiding this comment.
I feel like this whole approach could be simplified by just checking if {ty}: IntoIterator holds. You can use predicate_must_hold_modulo_regions to do this.
rustbot
added
S-waiting-on-author
d-sonuga
force-pushed
the
into-iter-sugg
branch
from
51a9e61
to
e99766d
Compare
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2024
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#119928 (suggest `into_iter()` when `Iterator` method called on `impl IntoIterator`) - rust-lang#121020 (Avoid an ICE in diagnostics) - rust-lang#121111 (For E0038, suggest associated type if available) - rust-lang#121137 (Add clippy into the known `cfg` list) - rust-lang#121179 (allow mutable references in const values when they point to no memory) - rust-lang#121181 (Fix an ICE in the recursion lint) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2024
Rollup merge of rust-lang#119928 - d-sonuga:into-iter-sugg, r=compiler-errors suggest `into_iter()` when `Iterator` method called on `impl IntoIterator` Fix for issue rust-lang#117711.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #117711.