Impl trait diagnostic tweaks #119703
Merged
Impl trait diagnostic tweaks #119703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? fmease or feel free to reassign if you don't want to review it 😆 |
fmease
approved these changes
Jan 7, 2024
| @@ -1,7 +1,7 @@ | |||
| struct Bug { | |||
| V1: [(); { | |||
| let f: impl core::future::Future<Output = u8> = async { 1 }; | |||
| //~^ `impl Trait` only allowed in function and inherent method argument and return types | |||
| //~^ `impl Trait` is not allowed in variable bindings | |||
There was a problem hiding this comment.
in variable bindings is fine but in the type of variable bindings is better imo, not super important
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
wait i'll fix that variable binding nit |
|
@bors r- |
bors
added
S-waiting-on-author
|
ok ok :) |
rust-cloud-vms
bot
force-pushed
the
impl-trait-tweaks
branch
from
94de510
to
7e38b70
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 7, 2024
… r=fmease Impl trait tweaks 1. Tweak some names for `impl Trait` being used in the wrong position 2. Remove two helper functions that are no longer needed since RPITIT is stable, and which causes matches to be a bit obtuse. 3. Split and fix the part where the error notes that it's "only allowed in XX" Fixes rust-lang#119629
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#116129 (Rewrite `pin` module documentation to clarify usage and invariants) - rust-lang#119702 (Miri subtree update) - rust-lang#119703 (Impl trait tweaks) - rust-lang#119705 (Support `~const` in associated functions in trait impls) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116129 (Rewrite `pin` module documentation to clarify usage and invariants) - rust-lang#119703 (Impl trait diagnostic tweaks) - rust-lang#119705 (Support `~const` in associated functions in trait impls) - rust-lang#119708 (Unions are not `PointerLike`) - rust-lang#119711 (Delete unused makefile in tests/ui) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
Rollup merge of rust-lang#119703 - compiler-errors:impl-trait-tweaks, r=fmease Impl trait diagnostic tweaks 1. Tweak some names for `impl Trait` being used in the wrong position 2. Remove two helper functions that are no longer needed since RPITIT is stable, and which causes matches to be a bit obtuse. 3. Split and fix the part where the error notes that it's "only allowed in XX" Fixes rust-lang#119629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl Traitbeing used in the wrong positionFixes #119629