-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #119437
Rollup of 5 pull requests #119437
Commits on Dec 20, 2023
-
Cleaned up alloc::sync::Weak Clone implementation
Since both return points (tail and early return) return the same expression and the only difference is whether inner is available, the code that does the atomic operations and checks on inner was moved into the if body and the only return is at the tail. Original comments preserved.
Configuration menu - View commit details
-
Copy full SHA for 0453d5f - Browse repository at this point
Copy the full SHA 0453d5fView commit details
Commits on Dec 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 12dd5d1 - Browse repository at this point
Copy the full SHA 12dd5d1View commit details
Commits on Dec 29, 2023
-
Primitive docs: fix confusing
Send
in&T
's listThe two lists in this document describe what traits are implemented on references when their underlying `T` also implements them. However, while it is true that `T: Send + Sync` implies `&T: Send` (which is what the sentence is trying to explain), it is confusing to have `Send` in the list because `T: Send` is not needed for that. In particular, the "also require" part may be interpreted as "both `T: Send` and `T: Sync` are required". Instead, move `Send` back to where it was before commit 7a47786 ("Makes docs for references a little less confusing"), i.e. to the `&mut` list (where no extra nota is needed, i.e. it fits naturally) and move the `Sync` definition/note to the bottom as something independent. Signed-off-by: Miguel Ojeda <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd928c8 - Browse repository at this point
Copy the full SHA dd928c8View commit details -
Signed-off-by: onur-ozkan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ca9950d - Browse repository at this point
Copy the full SHA ca9950dView commit details -
apply bootstrap lock unconditionally
Signed-off-by: onur-ozkan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 48309f4 - Browse repository at this point
Copy the full SHA 48309f4View commit details
Commits on Dec 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 621e241 - Browse repository at this point
Copy the full SHA 621e241View commit details -
Configuration menu - View commit details
-
Copy full SHA for a25e023 - Browse repository at this point
Copy the full SHA a25e023View commit details -
Rollup merge of rust-lang#119158 - JohnTheCoolingFan:arc-weak-clone-p…
…retty, r=cuviper Clean up alloc::sync::Weak Clone implementation Since both return points (tail and early return) return the same expression and the only difference is whether inner is available, the code that does the atomic operations and checks on inner was moved into the if body and the only return is at the tail. Original comments preserved.
Configuration menu - View commit details
-
Copy full SHA for c67ab2e - Browse repository at this point
Copy the full SHA c67ab2eView commit details -
Rollup merge of rust-lang#119386 - Emilgardis:typo-ipaddr-canonical-d…
…oc, r=est31 fix typo in `IpAddr::to_canonical`
Configuration menu - View commit details
-
Copy full SHA for b594dfa - Browse repository at this point
Copy the full SHA b594dfaView commit details -
Rollup merge of rust-lang#119413 - onur-ozkan:bump-fd-lock, r=Mark-Si…
…mulacrum solaris support on bootstrap lock With yoshuawuyts/fd-lock#48, `fd-lock` now supports Solaris. Therefore we no longer need to conditionally handle the bootstrap locks.
Configuration menu - View commit details
-
Copy full SHA for 31aa239 - Browse repository at this point
Copy the full SHA 31aa239View commit details -
Rollup merge of rust-lang#119424 - ojeda:send-sync, r=est31
Primitive docs: fix confusing `Send` in `&T`'s list The two lists in this document describe what traits are implemented on references when their underlying `T` also implements them. However, while it is true that `T: Send + Sync` implies `&T: Send` (which is what the sentence is trying to explain), it is confusing to have `Send` in the list because `T: Send` is not needed for that. In particular, the "also require" part may be interpreted as "both `T: Send` and `T: Sync` are required". Instead, move `Send` back to where it was before commit 7a47786 ("Makes docs for references a little less confusing"), i.e. to the `&mut` list (where no extra nota is needed, i.e. it fits naturally) and move the `Sync` definition/note to the bottom as something independent.
Configuration menu - View commit details
-
Copy full SHA for 19580d5 - Browse repository at this point
Copy the full SHA 19580d5View commit details -
Rollup merge of rust-lang#119425 - Urgau:check-cfg-fix-cargo-diag-bug…
…, r=Nilstrieb Fix invalid check-cfg Cargo feature diagnostic help rust-lang#118213 added specialized diagnostic for Cargo `feature` cfg. However when providing an empty `#[cfg(feature)]` condition the suggestion would suggest adding `feature` as a feature in `Cargo.toml` (wtf!). This PR removes the invalid logic, which even brings a nice improvement. ```diff --> $DIR/cargo-feature.rs:18:7 | LL | #[cfg(feature)] - | ^^^^^^^ + | ^^^^^^^- help: specify a config value: `= "bitcode"` | = note: expected values for `feature` are: `bitcode` - = help: consider defining `feature` as feature in `Cargo.toml` ``` The first commit add a test showing the bug and the second commit fixes the bug. `@rustbot` label +F-check-cfg
Configuration menu - View commit details
-
Copy full SHA for e930ea2 - Browse repository at this point
Copy the full SHA e930ea2View commit details