Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc,sync: Do not create references to uninitialized values #119433

Merged
merged 1 commit into from
Jan 23, 2024
Merged

rc,sync: Do not create references to uninitialized values #119433

merged 1 commit into from
Jan 23, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 30, 2023

Closes #119241

r? @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 30, 2023
@RalfJung
Copy link
Member

Sorry, I can't review libs changes.
r? libs

@rustbot rustbot assigned joshtriplett and unassigned RalfJung Dec 30, 2023
@taiki-e taiki-e mentioned this pull request Jan 7, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Noratrieb
Copy link
Member

Even if it's decided to not be UB, I think this still makes the code nicer. Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2024

📌 Commit 4e973b0 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#119433 - taiki-e:rc-uninit-ref, r=Nilstrieb
c6796b0 
rc,sync: Do not create references to uninitialized values

Closes rust-lang#119241

r? `@RalfJung`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2024
@bors
Auto merge of rust-lang#120249 - matthiaskrgr:rollup-h646lvq, r=matth…
8cf20db 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119433 (rc,sync: Do not create references to uninitialized values)
 - rust-lang#119460 (coverage: Never emit improperly-ordered coverage regions)
 - rust-lang#119766 (Split tait and impl trait in assoc items logic)
 - rust-lang#120160 (Manually implement derived `NonZero` traits.)
 - rust-lang#120177 (Remove duplicate dependencies for rustc)
 - rust-lang#120183 (Add `#[coverage(off)]` to closures introduced by `#[test]` and `#[bench]`)
 - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions)
 - rust-lang#120201 (Bump some deps with syn 1.0 dependencies)
 - rust-lang#120246 (Re-add estebank to review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jan 23, 2024

⌛ Testing commit 4e973b0 with merge dfe53af...

@bors
Copy link
Contributor

bors commented Jan 23, 2024

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing dfe53af to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 23, 2024
@bors bors merged commit dfe53af into rust-lang:master Jan 23, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 23, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dfe53af): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -5.5% [-5.5%, -5.5%] 1
Improvements ✅
(secondary)		 -3.1% [-3.1%, -3.1%] 1
All ❌✅ (primary) -5.5% [-5.5%, -5.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.3%, -0.2%] 4
All ❌✅ (primary) - - 0

Bootstrap: 662.447s -> 662.823s (0.06%)
Artifact size: 308.28 MiB -> 308.32 MiB (0.01%)

@taiki-e taiki-e deleted the rc-uninit-ref branch January 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@joshtriplett joshtriplett

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

Arc/Rc is creating references to uninitialized values
8 participants
@taiki-e @RalfJung @rust-log-analyzer @Noratrieb @bors @rust-timer @joshtriplett @rustbot