Don't validate / lint MIR before each pass

[tmiasko]

To avoid redundant work and verbose output in case of failures.

[rustbot]

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[compiler-errors]

Are we still validating MIR before the first pass (i.e. the raw, freshly-built MIR?)

@bors try @rust-timer queue

[bors]

⌛ Trying commit 8d77c2e with merge 6942d41...

[tmiasko]

Strictly speaking we don't validate MIR before the first pass. It doesn't seem much of a loss given that the first few passes are lints and don't mutate MIR.

[bors]

☀️ Try build successful - checks-actions
Build commit: 6942d41 (6942d418c1d6300a7c5c9d66f0584be5c6f026a9)

[rust-timer]

Finished benchmarking commit (6942d41): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[4.1%, 4.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.7%]	2
Regressions ❌ (secondary)	2.7%	[2.3%, 3.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.4%, 0.7%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.862s -> 672.719s (0.13%)
Artifact size: 312.35 MiB -> 312.33 MiB (-0.01%)

[cjgillot]

@bors r+ rollup-

[bors]

📌 Commit 8d77c2e has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8d77c2e with merge c2354aa...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing c2354aa to master...

[rust-timer]

Finished benchmarking commit (c2354aa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.614s -> 667.681s (-0.29%)
Artifact size: 311.77 MiB -> 311.77 MiB (0.00%)