mk: remove -fno-omit-frame-pointer #11879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still used for Rust code (`Options.NoFramePointerElim = true`).
|
It would be nice to disable this for Rust code too. However, we were not generating the expected debug information before and debuggers rely on this as a fallback when it is not present. |
| @@ -188,7 +182,6 @@ CFG_DEF_SUFFIX_i686-unknown-linux-gnu := .linux.def | |||
| CFG_LLC_FLAGS_i686-unknown-linux-gnu := | |||
| CFG_INSTALL_NAME_i686-unknown-linux-gnu = | |||
| CFG_LIBUV_LINK_FLAGS_i686-unknown-linux-gnu = | |||
| CFG_LLVM_BUILD_ENV_i686-unknown-linux-gnu="CXXFLAGS=-fno-omit-frame-pointer" | |||
There was a problem hiding this comment.
Let's not delete these lines from the makefile, but rather just leave them blank. I think that their presence helps suppress any usage of an undefined variable.
|
@alexcrichton: They're only defined for Linux and not the other platforms though. I could leave them and add empty lines for the other platforms, but it's pretty pointless if none are setting it. |
| @@ -128,6 +128,9 @@ pub mod write { | |||
| }; | |||
| let use_softfp = sess.opts.debugging_opts & session::USE_SOFTFP != 0; | |||
|
|
|||
| // FIXME: #11906: Omitting frame pointers currently breaks retrieving the value of a parameter. | |||
| let no_frame_pointer_elim = sess.opts.debugging_opts & session::DEBUG_INFO != 0; | |||
There was a problem hiding this comment.
This should use sess.opts.debuginfo instead of inspecting debugging_opts
This can almost be fully disabled, as it no longer breaks retrieving a backtrace on OS X as verified by @alexcrichton. However, it still breaks retrieving the values of parameters. This should be fixable in the future via a proper location list... Closes #7477
bors
added a commit
that referenced
this pull request
Jan 29, 2014
This is still used for Rust code (`Options.NoFramePointerElim = true`).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 1, 2023
`manual_try_fold`: check that `fold` is really `Iterator::fold` Fix rust-lang#11876 changelog: [`manual_try_fold`]: suggest using `try_fold` only for `Iterator::fold` uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still used for Rust code (
Options.NoFramePointerElim = true).