Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak parsing recovery of enums, for exprs and match arm patterns #117565

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Tweak parsing recovery of enums, for exprs and match arm patterns #117565

merged 13 commits into from
Nov 30, 2023

Commits on Nov 29, 2023

  1. Make parse_pat_ident not recover bad name

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    44fd3b4 View commit details
    Browse the repository at this point in the history

  2. When parsing patterns, bubble all errors except reserved idents that … 

    …aren't likely to appear in for head or match arm
    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ed084a9 View commit details
    Browse the repository at this point in the history

  3. More accurate span for unnecessary parens suggestion

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    075c599 View commit details
    Browse the repository at this point in the history

  4. Bubble parse error when expecting )

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1994abe View commit details
    Browse the repository at this point in the history

  5. Change enum parse recovery

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    db39068 View commit details
    Browse the repository at this point in the history

  6. Account for (pat if expr) => {} 

    When encountering match arm (pat if expr) => {}, recover and suggest removing parentheses. Fix rust-lang#100825.
    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c473189 View commit details
    Browse the repository at this point in the history

  7. Change how for (x in foo) {} is handled 

    Use the same approach used for match arm patterns.
    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0ff331b View commit details
    Browse the repository at this point in the history

  8. Fix test and move to more appropriate directory

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    bd1feb8 View commit details
    Browse the repository at this point in the history

  9. Fix tidy

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    147faa5 View commit details
    Browse the repository at this point in the history

  10. review comment: rework parse_for_head to reduce branching

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1575e6e View commit details
    Browse the repository at this point in the history

  11. Always emit help when failing to parse enum variant

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    4e52438 View commit details
    Browse the repository at this point in the history

  12. fix rebase

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    cb08634 View commit details
    Browse the repository at this point in the history

  13. Avoid unnecessary pattern parse errors on ref box

    @estebank
    estebank committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    88453aa View commit details
    Browse the repository at this point in the history