Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #117442

Closed
wants to merge 9 commits into from

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    48491c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bef3234 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    5b7cc9d View commit details
    Browse the repository at this point in the history
  2. coverage: Promote some debug-only checks to always run

    These checks should be cheap, so there's little reason for them to be
    debug-only.
    Zalathar committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8ef67d0 View commit details
    Browse the repository at this point in the history
  3. coverage: Replace impossible coverage::Error with assertions

    Historically, these errors existed so that the coverage debug code could dump
    additional information before reporting a compiler bug. That debug code was
    removed by rust-lang#115962, so we can now simplify these methods by making them panic
    when they detect a bug.
    Zalathar committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6d956a2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#117416 - compiler-errors:tait-in-bad-body, …

    …r=oli-obk
    
    Also consider TAIT to be uncomputable if the MIR body is tainted
    
    Not totally sure if this is the best solution. We could, alternatively, look at the hir typeck results and try to take a type from there instead of just falling back to type error, inferring `u8` instead of `{type error}`. Not certain it really matters, though.
    
    Happy to iterate on this.
    
    Fixes rust-lang#117413
    
    r? `@oli-obk` cc `@Nadrieril`
    matthiaskrgr authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b7acdff View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#117418 - compiler-errors:better_error_body,…

    … r=oli-obk
    
    Build a better MIR body when errors are encountered
    
    Doesn't really have much of an effect on its own, but it does lead to a less confusing phony MIR body being generated when an error is detected during THIR/MIR/match building. This was quite confusing when I hacked `-Zunpretty=mir` to emit `mir_built` rather than `instance_mir`.
    
    This coincidentually also fixes rust-lang#117413, but not as generally as rust-lang#117416.
    
    cc `@Nadrieril`
    matthiaskrgr authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8715479 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#117421 - Zalathar:error, r=oli-obk,Swatinem

    coverage: Replace impossible `coverage::Error` with assertions
    
    Historically, these errors existed so that the coverage debug code could dump additional information before reporting a compiler bug. That debug code was removed by rust-lang#115962, so we can now simplify these methods by making them panic immediately when they detect a bug.
    matthiaskrgr authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    bcdf6d2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#117438 - cjgillot:deterministic-error, r=ol…

    …i-obk
    
    Do not ICE on constant evaluation failure in GVN.
    
    Fixes rust-lang#117362
    matthiaskrgr authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9fe6420 View commit details
    Browse the repository at this point in the history