Run part of rustc_codegen_gcc's tests in CI

[GuillaumeGomez]

Thanks to #112701 and @bjorn3, it made this much easier.

Also cc @antoyo.

r? @bjorn3

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

[bjorn3]

At least the x86_64-gnu-llvm-15 runner doesn't have libgccjit installed.

[bjorn3]

2023-10-28T16:54:08.4668438Z   = note: /usr/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/arbitrary_self_types_pointers_and_wrappers.arbitrary_self_types_pointers_and_wrappers.4f746435a173466d-cgu.0.rcgu.o: in function `<i32 as core::fmt::Debug>::fmt':
2023-10-28T16:54:08.4669301Z           fake.c:(.text._RNvXs1g_NtNtCseVSX39tBz28_4core3fmt3numlNtB8_5Debug3fmtCs6OVZ8sMh4wz_42arbitrary_self_types_pointers_and_wrappers+0x5f): undefined reference to `core::fmt::num::__LT_impl_u20_core__fmt__LowerHex_u20_for_u20_i32_GT_::fmt'
2023-10-28T16:54:08.4670212Z           /usr/bin/ld: fake.c:(.text._RNvXs1g_NtNtCseVSX39tBz28_4core3fmt3numlNtB8_5Debug3fmtCs6OVZ8sMh4wz_42arbitrary_self_types_pointers_and_wrappers+0x81): undefined reference to `core::fmt::num::imp::__LT_impl_u20_core__fmt__Display_u20_for_u20_i32_GT_::fmt'
2023-10-28T16:54:08.4671109Z           /usr/bin/ld: fake.c:(.text._RNvXs1g_NtNtCseVSX39tBz28_4core3fmt3numlNtB8_5Debug3fmtCs6OVZ8sMh4wz_42arbitrary_self_types_pointers_and_wrappers+0xa3): undefined reference to `core::fmt::num::__LT_impl_u20_core__fmt__UpperHex_u20_for_u20_i32_GT_::fmt'
2023-10-28T16:54:08.4671270Z           collect2: error: ld returned 1 exit status

I presume it is trying to use a standard library compiled without -Csymbol-mangling-version=v0? By the way should cg_gcc maybe error out on -Csymbol-mangling-version=legacy?

[GuillaumeGomez]

I presume it is trying to use a standard library compiled without -Csymbol-mangling-version=v0?

Yes, but I don't understand how it's possible. The RUSTC_SYSROOT env variable is set and the -Zcodegen-backend=gcc flag is passed so I suppose it'll use this one. Maybe I'm missing something.

By the way should cg_gcc maybe error out on -Csymbol-mangling-version=legacy?

I'll let @antoyo decide on that.

[bors]

☔ The latest upstream changes (presumably #81746) made this pull request unmergeable. Please resolve the merge conflicts.

[antoyo]

By the way should cg_gcc maybe error out on -Csymbol-mangling-version=legacy?

I'll let @antoyo decide on that.

I don't mind keeping it available since it partly works.

[GuillaumeGomez]

cg_gcc tests passed again by modifying where we set the environment variables so time to give it another try.

@bors r=onur-ozkan

[bors]

📌 Commit c890dd6 has been approved by onur-ozkan

It is now in the queue for this repository.

[bors]

⌛ Testing commit c890dd6 with merge 6b9d6de...

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 6b9d6de to master...

[rust-timer]

Finished benchmarking commit (6b9d6de): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.7%	[-4.7%, -4.7%]	1
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-1.8%	[-4.7%, 1.1%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.745s -> 636.637s (-0.02%)
Artifact size: 304.48 MiB -> 304.47 MiB (-0.00%)

[GuillaumeGomez]

It finally passed! \o/