Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix miri target information for Test step #117287

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix miri target information for Test step #117287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bootstrap/src/core/build_steps/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ impl Step for Miri {
SourceType::InTree,
&[],
);
let _guard = builder.msg_sysroot_tool(Kind::Test, compiler.stage, "miri", host, host);
let _guard = builder.msg_sysroot_tool(Kind::Test, compiler.stage, "miri", host, target);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fff8223 duplicated a bunch of logic and some of it is wrong? I didn't think each test step has to do its own printing, and I think Miri had a "Testing Miri" header before fff8223... but I might misremember.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fff8223 duplicated a bunch of logic and some of it is wrong?

Others don't support the target field yet.


cargo.add_rustc_lib_path(builder, compiler);

Expand Down
Loading