clean up unneeded ToPredicate impls
#115566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
oli-obk
reviewed
Sep 5, 2023
Comment on lines
2192
to
2201
| let pred: ty::Predicate<'_> = ty::Binder::bind_with_vars( | ||
| ty::ProjectionPredicate { | ||
| projection_ty: tcx.mk_alias_ty(trait_ty.def_id, rebased_args), | ||
| term: normalize_impl_ty.into(), | ||
| }, | ||
| bound_vars, | ||
| ) | ||
| .to_predicate(tcx), | ||
| ), | ||
| .to_predicate(tcx); | ||
|
|
||
| predicates.push(pred.expect_clause()) |
There was a problem hiding this comment.
This is a bit roundabout. We should probably add a way to create clauses directly
There was a problem hiding this comment.
yea, considering all the uses work like that, adding a new method to Clause seems best.
There was a problem hiding this comment.
I suppose it's something like this?
impl Clause {
fn new(tcx: TyCtxt<'tcx>, pred: impl ToPredicate<'tcx>) -> Clause<'tcx> {
// ...
}
}
There was a problem hiding this comment.
just a ClauseKind as the argument. Even if internally you go through ToPredicate, there's nothing that can fail if the argument is ClauseKind
zirconium-n
force-pushed
the
issue-107250-clean-up-unused-to-predicate
branch
from
d263dc3 to
b62141e
Compare
|
Just realized I forgot to push the commit. Can't use |
This comment has been minimized.
This comment has been minimized.
zirconium-n
force-pushed
the
issue-107250-clean-up-unused-to-predicate
branch
from
b62141e to
3c69a10
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#115566 (clean up unneeded `ToPredicate` impls) - rust-lang#115962 (coverage: Remove debug code from the instrumentor) - rust-lang#115988 (rustdoc: add test cases, and fix, search tabs layout jank) - rust-lang#115991 (Ensure `build/tmp` exists in `rustdoc_themes::get_themes`) - rust-lang#115997 (RELEASES.md: Add missing patch releases) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
Rollup merge of rust-lang#115566 - zirconium-n:issue-107250-clean-up-unused-to-predicate, r=oli-obk clean up unneeded `ToPredicate` impls Part of rust-lang#107250. Removed all totally unused impls. And inlined two impls not need to satisify trait bound. r? `@oli-obk`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #107250.
Removed all totally unused impls. And inlined two impls not need to satisify trait bound.
r? @oli-obk