Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta #115446

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta #115446

merged 1 commit into from
Sep 1, 2023

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Sep 1, 2023

@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2023
@klensy
Copy link
Contributor Author

klensy commented Sep 1, 2023

r? @cuviper Asked in zulip

@rustbot rustbot assigned cuviper and unassigned jackh726 Sep 1, 2023
@klensy klensy changed the title fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and moved to beta fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta Sep 1, 2023
@cuviper
Copy link
Member

cuviper commented Sep 1, 2023

@rustbot label +beta-nominated

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit 355ba43 has been approved by cuviper

It is now in the queue for this repository.

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 1, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2023
@bors
Auto merge of rust-lang#115452 - matthiaskrgr:rollup-he30fhv, r=matth…
270eb58 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115411 (miri ABI check: fix handling of 1-ZST; don't accept sign differences)
 - rust-lang#115424 (diagnostics: avoid wrong `unused_parens` on `x as (T) < y`)
 - rust-lang#115425 (remove unnecessary heap allocation)
 - rust-lang#115446 (fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta)
 - rust-lang#115447 (Add comment so pub items are not removed)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db450d2 into rust-lang:master Sep 1, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 1, 2023
@apiraino
Copy link
Contributor

apiraino commented Sep 7, 2023

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 7, 2023
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 9, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.74.0, 1.73.0 Sep 9, 2023
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2023
@bors
Auto merge of rust-lang#115722 - Mark-Simulacrum:beta-backport, r=Mar…
ea99593 
…k-Simulacrum

[beta] backport

This PR backports:
- rust-lang#115559: implied bounds: do not ICE on unconstrained region vars
- rust-lang#115446: fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta
- rust-lang#115276: rustdoc: correctly deal with self ty params when eliding default object lifetimes

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
7 participants
@klensy @rustbot @cuviper @bors @apiraino @Mark-Simulacrum @jackh726