Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest removing redundant arguments in format!() #115324

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Suggest removing redundant arguments in format!() #115324

merged 12 commits into from
Oct 23, 2023

Commits on Oct 5, 2023

  1. Suggest removing redundant arguments in format!()

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    93df9e6 View commit details
    Browse the repository at this point in the history

  2. Separate report_redundant_placeholders() into its own function

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4cc2d0b View commit details
    Browse the repository at this point in the history

  3. Use diagnostic impls and add suggestions in redundant format!() args

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    04fc051 View commit details
    Browse the repository at this point in the history

  4. Rename report_redundant_placeholders() to report_redundant_format_arg… 

    …uments()
    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9c921f8 View commit details
    Browse the repository at this point in the history

  5. Document report_redundant_format_arguments()

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e1c18f4 View commit details
    Browse the repository at this point in the history

  6. Remove unused variable

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    dc75c99 View commit details
    Browse the repository at this point in the history

  7. Fix diagnostics being cancelled even with unused arguments

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4a7a98c View commit details
    Browse the repository at this point in the history

  8. Plurals in format redundant arguments suggestion

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fcdd5c0 View commit details
    Browse the repository at this point in the history

  9. Highlight redundant arguments instead of the whole format string

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    905bace View commit details
    Browse the repository at this point in the history

  10. Add suggestion test

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    38b0182 View commit details
    Browse the repository at this point in the history

  11. Only give autofix suggestion when no named args are present

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c8ee7db View commit details
    Browse the repository at this point in the history

  12. Keep fluent slugs in alphabetical order

    @francorbacho
    francorbacho committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cbc6b65 View commit details
    Browse the repository at this point in the history