Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test for #67992 #115174

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

davidtwco
Copy link
Member

Fixes #67992.

Just adding a regression test for this issue.

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2023
@davidtwco
Copy link
Member Author

davidtwco commented Aug 24, 2023

r? @wesleywiser (visited in wg-debugging triage)

Wrote the gdb half of this based on the output of another machine, but didn't actually get to run the test with gdb, so might fail at first in CI.

@rust-log-analyzer

This comment has been minimized.

@davidtwco davidtwco force-pushed the needs-test-bad-location-list-67992 branch from d840984 to b617e6d Compare August 24, 2023 13:36
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 24, 2023
@davidtwco davidtwco force-pushed the needs-test-bad-location-list-67992 branch from b617e6d to 0848ebd Compare August 25, 2023 09:31
@wesleywiser
Copy link
Member

Thanks @davidtwco!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 29, 2023

📌 Commit 0848ebd has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111580 (Don't ICE on layout computation failure)
 - rust-lang#114923 (doc: update lld-flavor ref)
 - rust-lang#115174 (tests: add test for rust-lang#67992)
 - rust-lang#115187 (Add new interface to smir)
 - rust-lang#115300 (Tweaks and improvements on SMIR around generics_of and predicates_of)
 - rust-lang#115340 (some more is_zst that should be is_1zst)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d5b12a2 into rust-lang:master Aug 29, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 29, 2023
@davidtwco davidtwco deleted the needs-test-bad-location-list-67992 branch September 6, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad location list debug info
6 participants