Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table issues in platform support documentation (closes #115047) #115055

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix table issues in platform support documentation (closes #115047) #115055

merged 1 commit into from
Aug 22, 2023

Conversation

Kriskras99
Copy link
Contributor

@Kriskras99 Kriskras99 commented Aug 21, 2023

mdBook needs an empty line before and after the table block.
In addition, in the tier-3 list three targets forgot about the host column and therefore showed the notes in the host column.

Closes #115047

@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2023
@ehuss
Copy link
Contributor

ehuss commented Aug 21, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2023

📌 Commit dfbac25 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2023
Fix table issues in platform support documentation (closes rust-lang#115047)

mdBook needs an empty line before and after the table block.
In addition, in the tier-3 list three targets forgot about the host column and therefore showed the notes in the host column.

Closes rust-lang#115047
@matthiaskrgr
Copy link
Member

@bors r-
looks like this failed in #115068 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2023
@Kriskras99
Copy link
Contributor Author

Kriskras99 commented Aug 21, 2023

@matthiaskrgr:

@bors r- looks like this failed in #115068 (comment)

I think the pull request that failed was #115011, this pull request only changes some markdown files in the rustc book.

@matthiaskrgr
Copy link
Member

Ooh sorry, yes makes sense :)
@bors r=ehuss

@bors
Copy link
Contributor

bors commented Aug 21, 2023

📌 Commit dfbac25 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2023
@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit dfbac25 with merge 32aa405...

@bors
Copy link
Contributor

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 32aa405 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 22, 2023
@bors bors merged commit 32aa405 into rust-lang:master Aug 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 22, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (32aa405): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.501s -> 634.782s (0.04%)
Artifact size: 347.06 MiB -> 347.03 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table broken in description of target aarch64-unknown-teeos
8 participants