ignore-cross-compile on optimization-remarks-dir-pgo test
#114958
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
The other PGO tests don't need this directive, so there should be something more subtle going on. Maybe running the produced binary should be done with a |
|
I'll take a look, r? lqd |
Discussing with @Veykril, the subtlety was that these tests are already ignored in ferrocene's CI. This is just the first PGO test being added after the initial set was ignored. This makes sense, as running the binary is not particularly conducive to cross-compilation anyways. We should also do this on the other tests (and ferrocene can then remove their ignores), but there's no need to do so in this PR. @bors r+ rollup |
bors
added
S-waiting-on-bors
…-pgo, r=lqd `ignore-cross-compile` on `optimization-remarks-dir-pgo` test We noticed this on our upstream pull on ferrocene a week ago as it was failing our CI. The test attempts to run the produced binary which won't work when cross compiling.
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#114953 (Add myself back to review rotation) - rust-lang#114958 (`ignore-cross-compile` on `optimization-remarks-dir-pgo` test) - rust-lang#114971 (Add doc aliases for trigonometry and other f32,f64 methods.) - rust-lang#114972 (Add a test to check that inline const is in required_consts) - rust-lang#114977 (Add `modulo` and `mod` as doc aliases for `rem_euclid`.) r? `@ghost` `@rustbot` modify labels: rollup
`ignore-cross-compile` remaining tests that run binaries Follow up to rust-lang#114958
`ignore-cross-compile` remaining tests that run binaries Follow up to rust-lang#114958
We noticed this on our upstream pull on ferrocene a week ago as it was failing our CI. The test attempts to run the produced binary which won't work when cross compiling.