Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename issue #114423 test files to include context #114491

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Rename issue #114423 test files to include context #114491

merged 1 commit into from
Aug 5, 2023

Conversation

sebastiantoh
Copy link
Contributor

@sebastiantoh sebastiantoh commented Aug 5, 2023 •
edited
Loading

Addresses feedback given in #114461 (comment)

r? @estebank

@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2023

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot rustbot assigned estebank and unassigned davidtwco Aug 5, 2023
@sebastiantoh sebastiantoh mentioned this pull request Aug 5, 2023
Merged
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2023

📌 Commit 5b8f921 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2023
@compiler-errors compiler-errors mentioned this pull request Aug 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2023
@bors
Auto merge of rust-lang#114492 - compiler-errors:rollup-lp4sfla, r=co…
fca59ab 
…mpiler-errors

Rollup of 5 pull requests

Successful merges:

 - rust-lang#114287 (update overflow handling in the new trait solver)
 - rust-lang#114475 (Migrate GUI colors test to original CSS color format)
 - rust-lang#114482 (Fix ui-fulldeps missing the `internal_features` lint on stage 0)
 - rust-lang#114490 (Fix a typo in the error reporting for sealed traits.)
 - rust-lang#114491 (Rename issue rust-lang#114423 test files to include context)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3222084 into rust-lang:master Aug 5, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 5, 2023
@sebastiantoh sebastiantoh deleted the add-context-to-issue-114423-test-names branch August 5, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastiantoh @rustbot @compiler-errors @bors @davidtwco @estebank