Soft deprecate Sink #114384
Closed
Soft deprecate Sink #114384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Noratrieb
reviewed
Aug 3, 2023
|
☔ The latest upstream changes (presumably #114104) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Alex Saveau <[email protected]>
Mark-Simulacrum
added
the
I-libs-api-nominated
|
Nominating for libs-api to decide if we want to do this. |
|
We discussed this in the libs-api meeting yesterday. We don't see any significant benefits to deprecating |
Amanieu
removed
the
I-libs-api-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Deprecate.20sink.3F