Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary Rc #113573

Merged
merged 1 commit into from
Jul 12, 2023
Merged

remove unnecessary Rc #113573

merged 1 commit into from
Jul 12, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 11, 2023

the typeck results are already in a RefCell, so we don't need to wrap its fields in an Rc

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2023
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine, since we're not cloning typeck results often

@lcnr
Copy link
Contributor Author

lcnr commented Jul 11, 2023

should be fine, since we're not cloning typeck results often

we should never clone typeck results 😅 do we clone them anywhere?

I guess

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 11, 2023
@bors
Copy link
Contributor

bors commented Jul 11, 2023

⌛ Trying commit e386d41 with merge 84b1ef56c10d7ddb2115a663ca036a31099bf869...

@compiler-errors
Copy link
Member

r=me with clean perf

@bors
Copy link
Contributor

bors commented Jul 11, 2023

☀️ Try build successful - checks-actions
Build commit: 84b1ef56c10d7ddb2115a663ca036a31099bf869 (84b1ef56c10d7ddb2115a663ca036a31099bf869)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (84b1ef56c10d7ddb2115a663ca036a31099bf869): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.5% [-4.5%, -4.5%] 1
Improvements ✅
(secondary)
-2.8% [-3.7%, -1.7%] 3
All ❌✅ (primary) -4.5% [-4.5%, -4.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-3.0%, -2.2%] 4
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.7s -> 656.833s (0.17%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 12, 2023
@workingjubilee
Copy link
Member

https://www.youtube.com/watch?v=h1mD-_DKHc0

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jul 12, 2023

📌 Commit e386d41 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2023
@bors
Copy link
Contributor

bors commented Jul 12, 2023

⌛ Testing commit e386d41 with merge 910be1b...

@bors
Copy link
Contributor

bors commented Jul 12, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 910be1b to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jul 12, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 910be1b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 12, 2023
@bors bors merged commit 910be1b into rust-lang:master Jul 12, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 12, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (910be1b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [1.2%, 2.3%] 2
Regressions ❌
(secondary)
3.5% [3.2%, 3.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) 1.7% [1.2%, 2.3%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.52s -> 657.866s (0.05%)

@lcnr lcnr deleted the typeck-results branch July 13, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants