Dynamically size sigaltstk in std #113525

workingjubilee · 2023-07-10T08:57:46Z

On modern Linux with Intel AMX and 1KiB matrices,
Arm SVE with potentially 2KiB vectors,
and RISCV Vectors with up to 16KiB vectors,
we must handle dynamic signal stack sizes.

We can do so unconditionally by using getauxval,
but assuming it may return 0 as an answer,
thus falling back to the old constant if needed.

Fixes #107795

rustbot · 2023-07-10T08:57:53Z

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

workingjubilee · 2023-07-10T10:15:25Z

library/std/src/sys/unix/stack_overflow.rs

+    /// Not all OS support hardware where this is needed.
+    #[cfg(not(any(target_os = "linux", target_os = "android")))]
+    fn sigstack_size() -> usize {
+        libc::SIGSTKSZ
+    }


Though "support hardware where this is needed" is confounded: on Darwin e.g. they simply define MINSIGSTKSZ and SIGSTKSZ to be values with actually decent sizes since they have a strong idea of the lower and upper bound for their hardware support.

library/std/src/sys/unix/stack_overflow.rs

bors · 2024-01-13T16:30:24Z

☔ The latest upstream changes (presumably #117285) made this pull request unmergeable. Please resolve the merge conflicts.

m-ou-se

r=me after rebasing!

workingjubilee · 2024-03-06T18:10:40Z

ayo!

On modern Linux with Intel AMX and 1KiB matrices, Arm SVE with potentially 2KiB vectors, and RISCV Vectors with up to 16KiB vectors, we must handle dynamic signal stack sizes. We can do so unconditionally by using getauxval, but assuming it may return 0 as an answer, thus falling back to the old constant if needed.

workingjubilee · 2024-03-06T18:23:51Z

@bors r=m-ou-se

bors · 2024-03-06T18:23:53Z

📌 Commit 9da004e has been approved by m-ou-se

It is now in the queue for this repository.

…igstksz, r=m-ou-se Dynamically size sigaltstk in std On modern Linux with Intel AMX and 1KiB matrices, Arm SVE with potentially 2KiB vectors, and RISCV Vectors with up to 16KiB vectors, we must handle dynamic signal stack sizes. We can do so unconditionally by using getauxval, but assuming it may return 0 as an answer, thus falling back to the old constant if needed. Fixes rust-lang#107795

…kingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#113525 (Dynamically size sigaltstk in std) - rust-lang#114009 (compiler: allow transmute of ZST arrays with generics) - rust-lang#116793 (Allow targets to override default codegen backend) - rust-lang#118623 (Improve std::fs::read_to_string example) - rust-lang#120504 (Vec::try_with_capacity) - rust-lang#121089 (Remove `feed_local_def_id`) - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from}) - rust-lang#122087 (Add missing background color for top-level rust documentation page and increase contrast by setting text color to black) - rust-lang#122104 (Rust is a proper name: rust → Rust) - rust-lang#122110 (Make `x t miri` respect `MIRI_TEMP`) - rust-lang#122114 (Make not finding core a fatal error) - rust-lang#122115 (Cancel parsing ever made during recovery) - rust-lang#122126 (Fix `tidy --bless` on ̶X̶e̶n̶i̶x̶ Windows) r? `@ghost` `@rustbot` modify labels: rollup

…igstksz, r=m-ou-se Dynamically size sigaltstk in std On modern Linux with Intel AMX and 1KiB matrices, Arm SVE with potentially 2KiB vectors, and RISCV Vectors with up to 16KiB vectors, we must handle dynamic signal stack sizes. We can do so unconditionally by using getauxval, but assuming it may return 0 as an answer, thus falling back to the old constant if needed. Fixes rust-lang#107795

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#112136 (Add std::ffi::c_str module) - rust-lang#113525 (Dynamically size sigaltstk in std) - rust-lang#121561 (Detect typos for compiletest test directives) - rust-lang#121685 (Fixing shellcheck comments on lvi test script) - rust-lang#121833 (Suggest correct path in include_bytes!) - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once) - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds) - rust-lang#122221 (match lowering: define a convenient struct) - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error) - rust-lang#122264 (add myself to rotation) r? `@ghost` `@rustbot` modify labels: rollup

…igstksz, r=m-ou-se Dynamically size sigaltstk in std On modern Linux with Intel AMX and 1KiB matrices, Arm SVE with potentially 2KiB vectors, and RISCV Vectors with up to 16KiB vectors, we must handle dynamic signal stack sizes. We can do so unconditionally by using getauxval, but assuming it may return 0 as an answer, thus falling back to the old constant if needed. Fixes rust-lang#107795

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#112136 (Add std::ffi::c_str module) - rust-lang#113525 (Dynamically size sigaltstk in std) - rust-lang#121685 (Fixing shellcheck comments on lvi test script) - rust-lang#121833 (Suggest correct path in include_bytes!) - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once) - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds) - rust-lang#122221 (match lowering: define a convenient struct) - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes) - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error) - rust-lang#122264 (add myself to rotation) r? `@ghost` `@rustbot` modify labels: rollup

…igstksz, r=m-ou-se Dynamically size sigaltstk in std On modern Linux with Intel AMX and 1KiB matrices, Arm SVE with potentially 2KiB vectors, and RISCV Vectors with up to 16KiB vectors, we must handle dynamic signal stack sizes. We can do so unconditionally by using getauxval, but assuming it may return 0 as an answer, thus falling back to the old constant if needed. Fixes rust-lang#107795

…iaskrgr Rollup of 14 pull requests Successful merges: - rust-lang#112136 (Add std::ffi::c_str module) - rust-lang#113525 (Dynamically size sigaltstk in std) - rust-lang#121567 (Avoid some interning in bootstrap) - rust-lang#121642 (Update a test to support Symbol Mangling V0) - rust-lang#121685 (Fixing shellcheck comments on lvi test script) - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once) - rust-lang#121942 (std::rand: enable getrandom for dragonflybsd too.) - rust-lang#122125 (Revert back to Git-for-Windows for MinGW CI builds) - rust-lang#122221 (match lowering: define a convenient struct) - rust-lang#122244 (fix: LocalWaker memory leak and some stability attributes) - rust-lang#122251 (Add test to check unused_lifetimes don't duplicate "parameter is never used" error) - rust-lang#122264 (add myself to rotation) - rust-lang#122269 (doc/rustc: Move loongarch64-unknown-linux-musl to Tier 3) - rust-lang#122271 (Fix legacy numeric constant diag items) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#113525 - workingjubilee:handle-dynamic-minsigstksz, r=m-ou-se Dynamically size sigaltstk in std On modern Linux with Intel AMX and 1KiB matrices, Arm SVE with potentially 2KiB vectors, and RISCV Vectors with up to 16KiB vectors, we must handle dynamic signal stack sizes. We can do so unconditionally by using getauxval, but assuming it may return 0 as an answer, thus falling back to the old constant if needed. Fixes rust-lang#107795

rustbot assigned m-ou-se Jul 10, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 10, 2023

workingjubilee mentioned this pull request Jul 10, 2023

Dynamically size sigaltstk in rustc #113528

Merged

This comment has been minimized.

Sign in to view

workingjubilee force-pushed the handle-dynamic-minsigstksz branch from 5d3914c to 3f928e1 Compare July 10, 2023 09:30

workingjubilee commented Jul 10, 2023

View reviewed changes

the8472 reviewed Jul 10, 2023

View reviewed changes

library/std/src/sys/unix/stack_overflow.rs Outdated Show resolved Hide resolved

This was referenced Jul 10, 2023

MINSIGSTKSZ is no longer a constant rust-lang/libc#3299

Open

How to enable Intel AMX in asm! on Linux? #107795

Closed

m-ou-se approved these changes Feb 14, 2024

View reviewed changes

m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2024

workingjubilee force-pushed the handle-dynamic-minsigstksz branch from 3f928e1 to 9da004e Compare March 6, 2024 18:12

rustbot added the O-unix Operating system: Unix-like label Mar 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2024

workingjubilee mentioned this pull request Mar 7, 2024

Rollup of 13 pull requests #122131

Closed

workingjubilee mentioned this pull request Mar 10, 2024

Rollup of 10 pull requests #122265

Closed

matthiaskrgr mentioned this pull request Mar 10, 2024

Rollup of 10 pull requests #122273

Closed

This was referenced Mar 10, 2024

Rollup of 11 pull requests #122280

Closed

Rollup of 14 pull requests #122283

Merged

bors merged commit b81678e into rust-lang:master Mar 10, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 10, 2024

workingjubilee deleted the handle-dynamic-minsigstksz branch March 10, 2024 19:05

tustvold mentioned this pull request May 13, 2024

Rustc 1.78 Undefined Reference to getauxval #125067

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamically size sigaltstk in std #113525

Dynamically size sigaltstk in std #113525

workingjubilee commented Jul 10, 2023

rustbot commented Jul 10, 2023

This comment has been minimized.

workingjubilee Jul 10, 2023

bors commented Jan 13, 2024

m-ou-se left a comment

workingjubilee commented Mar 6, 2024

workingjubilee commented Mar 6, 2024

bors commented Mar 6, 2024

Dynamically size sigaltstk in std #113525

Dynamically size sigaltstk in std #113525

Conversation

workingjubilee commented Jul 10, 2023

rustbot commented Jul 10, 2023

This comment has been minimized.

workingjubilee Jul 10, 2023

Choose a reason for hiding this comment

bors commented Jan 13, 2024

m-ou-se left a comment

Choose a reason for hiding this comment

workingjubilee commented Mar 6, 2024

workingjubilee commented Mar 6, 2024

bors commented Mar 6, 2024