-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing clippy tests #113455
Fix failing clippy tests #113455
Conversation
Comments out the C string literals due to rust-lang#113334 Fixes rust-lang/rust-clippy#11121
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
I also just put up a PR up in clippy (that also slightly improves other code in the file) :D |
Fix failing clippy tests Comments out the C string literals due to rust-lang#113334 Fixes rust-lang/rust-clippy#11121 Opened against `rust-lang/rust` in order to unblock rust-lang#113450 r? `@Nilstrieb`
Fix failing clippy tests Comments out the C string literals due to rust-lang#113334 Fixes rust-lang/rust-clippy#11121 Opened against `rust-lang/rust` in order to unblock rust-lang#113450 r? ``@Nilstrieb``
☀️ Test successful - checks-actions |
Finished benchmarking commit (eee6b31): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 655.85s -> 655.621s (-0.03%) |
Dropping beta labels as this made it into 1.72. |
Comments out the C string literals due to #113334
Fixes rust-lang/rust-clippy#11121
Opened against
rust-lang/rust
in order to unblock #113450r? @Nilstrieb