Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reveal opaques in new solver #113335

Merged
merged 3 commits into from
Jul 8, 2023
Merged

Reveal opaques in new solver #113335

merged 3 commits into from
Jul 8, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jul 4, 2023 •
edited
Loading

We were testing against the wrong reveal mode 😨

Also a couple of misc commits that I don't want to really put in separate prs

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor

lcnr commented Jul 4, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 4, 2023

📌 Commit 51d7111 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 5, 2023
@Dylan-DPC
Rollup merge of rust-lang#113335 - compiler-errors:reveal-opaques-in-…
0d238c2 
…new-solver, r=lcnr

Reveal opaques in new solver

We were testing against the wrong reveal mode 😨

Also a couple of misc commits that I don't want to really put in separate prs

r? `@lcnr`
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 5, 2023
Closed
@compiler-errors
Copy link
Member Author

@bors r- needs bless

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2023
@compiler-errors compiler-errors force-pushed the reveal-opaques-in-new-solver branch 2 times, most recently from 43a0f4a to 5ad62bf Compare July 6, 2023 07:22
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the reveal-opaques-in-new-solver branch from 5ad62bf to 3247275 Compare July 6, 2023 17:06
@compiler-errors
Copy link
Member Author

Had to add -Zdeduplicate-diagnostics=yes because it seems like the number of cycle errors emitted is platform-specific. I have literally no idea why that's the case, but I really don't care to fight the compiler to fix what amounts to a known-bug...

@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Jul 6, 2023

📌 Commit 3247275 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#113335 - compiler-errors:reveal-opaques-in-…
172620c 
…new-solver, r=lcnr

Reveal opaques in new solver

We were testing against the wrong reveal mode 😨

Also a couple of misc commits that I don't want to really put in separate prs

r? `@lcnr`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 6, 2023
Closed
@compiler-errors
Copy link
Member Author

@bors r-

waiting until #112825 to land, because it conflicts with this one: #113420 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the reveal-opaques-in-new-solver branch from 3247275 to f55b046 Compare July 7, 2023 16:08
@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Jul 7, 2023

📌 Commit f55b046 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 7, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 7, 2023
@matthiaskrgr
Rollup merge of rust-lang#113335 - compiler-errors:reveal-opaques-in-…
c4925c7 
…new-solver, r=lcnr

Reveal opaques in new solver

We were testing against the wrong reveal mode 😨

Also a couple of misc commits that I don't want to really put in separate prs

r? ``@lcnr``
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 7, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 7, 2023
@GuillaumeGomez
Rollup merge of rust-lang#113335 - compiler-errors:reveal-opaques-in-…
017086a 
…new-solver, r=lcnr

Reveal opaques in new solver

We were testing against the wrong reveal mode 😨

Also a couple of misc commits that I don't want to really put in separate prs

r? ```@lcnr```
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 7, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request Jul 8, 2023
Merged
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jul 8, 2023
@compiler-errors
Rollup merge of rust-lang#113335 - compiler-errors:reveal-opaques-in-…
1f98612 
…new-solver, r=lcnr

Reveal opaques in new solver

We were testing against the wrong reveal mode 😨

Also a couple of misc commits that I don't want to really put in separate prs

r? ````@lcnr````
@compiler-errors compiler-errors mentioned this pull request Jul 8, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2023
@bors
Auto merge of rust-lang#113484 - matthiaskrgr:rollup-goq2u0d, r=matth…
d1389b9 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112931 (Enable zlib in LLVM on aarch64-apple-darwin)
 - rust-lang#113158 (tests: unset `RUSTC_LOG_COLOR` in a test)
 - rust-lang#113173 (CI: include workflow name in concurrency group)
 - rust-lang#113335 (Reveal opaques in new solver)
 - rust-lang#113390 (CGU formation tweaks)
 - rust-lang#113399 (Structurally normalize again for byte string lit pat checking)
 - rust-lang#113412 (Add basic types to SMIR)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3f1b03 into rust-lang:master Jul 8, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 8, 2023
@compiler-errors compiler-errors deleted the reveal-opaques-in-new-solver branch August 11, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @lcnr @bors @rust-log-analyzer