-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mips*-unknown-linux-gnu*
builders
#113274
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
...of course I forget to r? @ghost |
Failed to set assignee to
|
(asking for my own curiosity, not really suggesting anything) is there a need to remove all the |
git preserves all history, if one needs to be a git historian. |
Given that commits can also be easily reverted, I have received a recommendation that we should in fact remove these builders immediately, rather than waiting, as the burden has made it so essentially every PR merged lately has had one bors retry (...averaged). Which is fine by me, assuming that I did this correctly and everyone's on board. I will remove the "formally change the platform support page" commit to another PR. |
2384012
to
41a8376
Compare
mips*-unknown-linux-gnu*
to tier 3mips*-unknown-linux-gnu*
builders
But there some folder with promising name https://github.com/rust-lang/rust/tree/master/src/ci/docker/host-x86_64/disabled |
I don't think this should touch anything more than the CI configuration. |
So just 634f952 ? |
41a8376
to
634f952
Compare
@bors r+ p=50 rollup=never |
⌛ Testing commit 634f952 with merge 2c2f5cf020a890a48e8b4ff87ccad8cfdf118be1... |
@bors ping |
😪 I'm awake I'm awake |
gonna bump this auto build out of the queue, hope that's the right step here to make sure things don't get worse :( @bors retry |
(haha, bors probably wouldn't have even merged 634f952 because it's not a fast forward.) |
@bors r- p=50 |
I think this can resume build now, thanks @Mark-Simulacrum for fixing the tree. |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
The merge looks correct |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Or not? |
Actually, that looks like a previous auto-merge, not this one. |
should this retry then? |
No need -- it's merging successfully in https://github.com/rust-lang-ci/rust/actions/runs/5457834781 |
Weird. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (9e4e584): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.659s -> 653.846s (0.03%) |
Update docs for mips target tier demotion. These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.
Update docs for mips target tier demotion. These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.
Rollup merge of rust-lang#116503 - ehuss:fix-mips-tier, r=Amanieu Update docs for mips target tier demotion. These mips targets were demoted in rust-lang#113274, but the documentation was not updated. I have also elected to document this in the release notes for 1.72 because I think that should have been included.
Pursuant to the current consensus in rust-lang/compiler-team#648