Don't pass --test-args to python -m unitest
#113234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The args for unittest and cargo test are mutually incompatible. Suggest that people use `python -m unittest ...` manually instead. This also changes `bootstrap_test.py` to be easier to run standalone; see the commit for details.
rustbot
added
S-waiting-on-review
|
@hi-rustin You recently asked about running a single test in bootstrap, this restores the ability to do that😀 @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113147 (Fix document examples of Vec::from_raw_parts and Vec::from_raw_parts_in) - rust-lang#113202 (std docs: factorize literal in Barrier example) - rust-lang#113228 (Migrate GUI colors test to original CSS color format) - rust-lang#113231 (Fix `dropping_copy_types` lint from linting in match-arm with side-effects) - rust-lang#113233 (Update chalk) - rust-lang#113234 (Don't pass --test-args to `python -m unitest`) - rust-lang#113244 (Make Rust Analyzer tests faster by compiling less code) - rust-lang#113249 (Document tracking issue for rustdoc `show-type-layout`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The args for unittest and cargo test are mutually incompatible. Suggest that people use
python -m unittest ...manually instead.This also changes
bootstrap_test.pyto be easier to run standalone; see the commit for details.r? @clubby789 cc #112281 (comment)