Move some docs from the README to the dev-guide #113008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almost no one on windows builds from source unless they're contributing, and `./x.py` just works on most unix systems.
|
@bors rollup |
|
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
jyn514
force-pushed
the
new-contributor-improvements
branch
from
363918e
to
e9d83bf
Compare
jyn514
commented
Jun 24, 2023
jyn514
force-pushed
the
new-contributor-improvements
branch
from
e9d83bf
to
96f7bfc
Compare
jyn514
commented
Jun 24, 2023
Before: ``` PS C:\Users\vboxuser\rust> ./x x.ps1 PS C:\Users\vboxuser\rust> ``` After: ``` PS C:\Users\vboxuser\rust> ./x x.ps1 C:\Users\vboxuser\rust\x.ps1 : C:\Users\vboxuser\rust\x.ps1: error: did not find python installed help: consider installing it from https://www.python.org/downloads/windows/ At line:1 char:1 + ./x + ~~~ + CategoryInfo : NotInstalled: (:) [Write-Error], WriteErrorException + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,x.ps1 ``` The existing message from the shell script is already decent and I decided not to change it: ``` $ ./x Python was not found but can be installed from the Microsoft Store: ms-windows-store://pdp/?productid=9NJ46SX7X90P ```
This is left over from adding `Get-Command -syntax`; it's not helpful.
jyn514
force-pushed
the
new-contributor-improvements
branch
from
96f7bfc
to
664ffa4
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 25, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112937 (rustdoc: Align search results horizontally for easy scanning) - rust-lang#112950 (DirEntry::file_name: improve explanation) - rust-lang#112956 (Expose `compiler-builtins-weak-intrinsics` feature for `-Zbuild-std`) - rust-lang#113008 (Move some docs from the README to the dev-guide) - rust-lang#113009 (Remove unnecessary `path` attribute) r? `@ghost` `@rustbot` modify labels: rollup
|
I haven't yet verified this, but I think it breaks people like me who use the Store's python. |
|
I don't want to make a Microsoft account to test this. If you could post the error you see, that would be very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and as a drive-by cleanup, improve the error message for
x test tidywhen a feature gate is missing.This also improves the error message you get on Windows if python isn't installed.
cc rust-lang/libs-team#242 (comment), rust-lang/rustc-dev-guide#1701