Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Structurally resolve correctly in check_pat_lit" #113007

Merged

Conversation

compiler-errors
Copy link
Member

This reverts commit 54fb5a4. Also adds a couple of tests, and downgrades the existing -Ztrait-solver=next test to a known-bug.

Fixes #112993

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 24, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 25, 2023

@bors r+ rollup

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned eholk Jun 25, 2023
@bors
Copy link
Contributor

bors commented Jun 25, 2023

📌 Commit e304a1f has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2023
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#113007 (Revert "Structurally resolve correctly in check_pat_lit")
 - rust-lang#113023 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 75f6a7a into rust-lang:master Jun 25, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 25, 2023
@compiler-errors compiler-errors deleted the dont-structural-resolve-byte-str-pat branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type inference regression
5 participants