-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup azure leftovers #112663
cleanup azure leftovers #112663
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
The Miri subtree was changed cc @rust-lang/miri |
What part of should be removed? rust/src/bootstrap/toolstate.rs Lines 358 to 383 in f9097f8
can this be changed back to https? Lines 153 to 164 in f9097f8
|
Not really much, it's the same procedure even though it's now on GitHub Actions.
I'd keep it as http: date drifts could cause validation of the tls certificate to fail, while the whole purpose of the check is to detect date drifts. |
Current changes look good, let me know if you want to make more here or if I should approve this 🙂 |
Let's merge, no new ideas here yet. |
@bors r+ |
…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#112537 (Don't record adjustments twice in `note_source_of_type_mismatch_constraint`) - rust-lang#112663 (cleanup azure leftovers) - rust-lang#112668 (Test `x.ps1` in `msvc` CI job) - rust-lang#112710 (Re-use the deref-pattern recursion instead of duplicating the logic) - rust-lang#112753 (Don't try to auto-bless 32-bit `mir-opt` tests on ARM Mac hosts) - rust-lang#112758 (refactor(resolve): delete update_resolution function) r? `@ghost` `@rustbot` modify labels: rollup
Continuation of #97756