Add Terminator::InlineAsm conversion from MIR to SMIR #112395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
spastorino
force-pushed
the
smir-terminator-3
branch
2 times, most recently
from
0e3cd7a to
2431728
Compare
oli-obk
reviewed
Jun 8, 2023
spastorino
force-pushed
the
smir-terminator-3
branch
from
570eeb2 to
891d6a9
Compare
oli-obk
requested changes
Jun 8, 2023
spastorino
force-pushed
the
smir-terminator-3
branch
2 times, most recently
from
2b711d6 to
1dfb036
Compare
spastorino
force-pushed
the
smir-terminator-3
branch
from
1dfb036 to
313143b
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 9, 2023
…i-obk Add Terminator::InlineAsm conversion from MIR to SMIR This is the last variant that needed to be covered for Terminator. As we've discussed with `@oli-obk` I've made a lot of it's fields be `String`s. r? `@oli-obk`
This was referenced Jun 9, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112323 (Don't mention already-set fields in struct constructor missing field error) - rust-lang#112395 (Add Terminator::InlineAsm conversion from MIR to SMIR) - rust-lang#112411 (add programmerjake to portable-simd cc list) - rust-lang#112428 (Structurally resolve pointee in `check_pat_lit`) - rust-lang#112444 (Don't debug-print `Interned` or `PrivateZst`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last variant that needed to be covered for Terminator. As we've discussed with @oli-obk I've made a lot of it's fields be
Strings.r? @oli-obk