offset_of: don't require type to be Sized
#112069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
offset-of-sized-fields
branch
from
ef34b27 to
bd587fd
Compare
This comment has been minimized.
This comment has been minimized.
|
Hmm, it looks like these tests are testing things that the RFC currently disallows 🤔 |
|
The RFC is intentionally limited to allow a pure library implementation. My implementation also included several of the future possibilities, including supporting DSTs. |
|
I don't think there are any implementation concerns with allowing unsized fields, so there's no reason not to. |
|
Yeah the ability to get the offset of fields that are part of the sized prelude of an unsized type would be great. This is one of the things that is impossible to do (in a sound way) in libraries but it is needed by the users of one of the projects I maintain. |
rust-cloud-vms
bot
force-pushed
the
offset-of-sized-fields
branch
from
bd587fd to
4b1b9a1
Compare
rust-cloud-vms
bot
force-pushed
the
offset-of-sized-fields
branch
from
4b1b9a1 to
6c18d1e
Compare
clubby789
changed the title
Sized
WaffleLapkin
approved these changes
May 30, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 30, 2023
…r=WaffleLapkin offset_of: don't require type to be `Sized` Fixes rust-lang#112051 ~~The RFC [explicitly forbids](https://rust-lang.github.io/rfcs/3308-offset_of.html#limitations) non-`Sized` types, but it looks like only the fields being recursed into were checked. The sized check also seemed to have been completely missing for tuples~~
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112031 (Migrate `item_proc_macro` to Askama) - rust-lang#112053 (Remove `-Zcgu-partitioning-strategy`.) - rust-lang#112069 (offset_of: don't require type to be `Sized`) - rust-lang#112084 (enhancements on build_helper utilization and rustdoc-gui-test) - rust-lang#112096 (Remove array_zip) - rust-lang#112108 (Fix re-export of doc hidden item inside private item not displayed) - rust-lang#112113 (rustdoc: simplify `clean` by removing `FnRetTy`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112051
The RFC explicitly forbids non-Sizedtypes, but it looks like only the fields being recursed into were checked. The sized check also seemed to have been completely missing for tuples