-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate docs for bootstrap itself #111976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This verifies the intra-doc links are correct, and hopefully makes things easier for new contributors.
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
May 26, 2023
i already assigned 3 of the 4 reviewers on the team tonight so what the hell, may as well make it a full house 😄 and this avoids assigning mark twice r? @ozkanonur |
onur-ozkan
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 26, 2023
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 26, 2023
Generate docs for bootstrap itself This verifies the intra-doc links are correct, and hopefully makes things easier for new contributors. Note that this will conflict with rust-lang#111955, i'm pretty sure i typo-ed some of the intra-doc links lol
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 26, 2023
Generate docs for bootstrap itself This verifies the intra-doc links are correct, and hopefully makes things easier for new contributors. Note that this will conflict with rust-lang#111955, i'm pretty sure i typo-ed some of the intra-doc links lol
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#111714 (Stop confusing specification levels when computing expectations.) - rust-lang#111927 (Migrate `item_static` to Askama) - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee) - rust-lang#111973 (Update current implementation comments for `select_nth_unstable`) - rust-lang#111976 (Generate docs for bootstrap itself) - rust-lang#111977 (Make errors from `x doc` less verbose) - rust-lang#111987 (do not prefer substs relate during coherence) - rust-lang#111991 (Change ty and const error's pretty printing to be in braces) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies the intra-doc links are correct, and hopefully makes things easier for new contributors.
Note that this will conflict with #111955, i'm pretty sure i typo-ed some of the intra-doc links lol