-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward features from library/test #111234
Forward features from library/test #111234
Conversation
Failing to do this breaks a bunch of build systems, so let's give them a few nights of overlap to migrate.
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Cargo is already fixing this in rust-lang/cargo#12088. Does it still make sense to land both changes? |
I think this would help smooth the migration for miscellaneous other users yeah. I don't feel strongly that we must land it if cargo has patched in a fix, as they're the big one to avoid breaking. |
r=me unless you want to wait for Ehuss @bors delegate=workingjubilee p=1 (important to land this before next nightly if we're going to do it at all) |
✌️ @workingjubilee can now approve this pull request |
Does this essentially negate the benefits of #108865? I'm concerned overall about the structural changes in #108865, since there will likely be other users of the std source component who will be affected. Is the intent to have them migrate to using |
Ah, thanks for letting me know. If you no longer believe it is beneficial to make things easier for people to migrate, then I can just close this. |
I will note: my off-center view of time and my tendency to understatement means "a few nights" can mean anywhere between "3 nights" and "99 nights", for me. I am normally someone who does have reason to compile the stdlib using my own set of build instructions, so #108865 did affect me, but at the same time I don't update the compiler version often enough for this to be a serious concern. |
Failing to do this breaks a bunch of build systems, so let's give them a few nights of overlap to migrate.
r? @ehuss